Drain autologin bits into mantle #1270
Conversation
This got subtly broken in a refactoring; we need to infer the ignition version from the disk image name if no cosa build is provided. This is necessary for handling `cosa run -d /path/to/rhcos-4.2.0.qcow2`.
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Some minor comments, but LGTM as is too!
| ignition = newconfig | ||
| cleanupIgnition = true | ||
| } | ||
| if kola.Options.IgnitionVersion == "v2" { |
There was a problem hiding this comment.
Minor: just so I understand, this if-statement isn't related to the autologin draining, right? Feels like it's worth its own commit.
There was a problem hiding this comment.
It's necessary now because previously cosa run worked with RHCOS, but kola qemuexec required external translation.
There was a problem hiding this comment.
We have a similar version of this down translation code in a few places. Might end up being worthwhile to move more into the Conf / UserData struct and providing a stable interface to perform translation from there.
I want to use this for live ISO testing, since being able to debug on the console is super useful. Also, this helps drain `cmd-run` into mantle. `qemuexec` is slowly becoming something nontrivial...but most of that mess is the Ignition conversion bits which are duplicated around.
cgwalters
force-pushed
the
kola-autologin
branch
from
4576f43 to
6b00097
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
I want to use this for live ISO testing, since being able to debug
on the console is super useful.
Also, this helps drain
cmd-runinto mantle.qemuexecis slowly becoming something nontrivial...but mostof that mess is the Ignition conversion bits which are duplicated
around.