fix(ci): persist identity-resolution appVersion bumps back to main - #1939
Merged
Conversation
The bump-descriptors and "commit version bumps back to main" steps in build-images.yml staged a hardcoded list of backend subchart Chart.yaml files that never included src/backend/services/identity-resolution/helm/Chart.yaml (bump-service- appversions.sh does bump it correctly in the run's workspace — it's just never git-added, so the bump is silently discarded). #1890 fixed the identical gap for authenticator/gateway three days earlier; identity-resolution landed as a subchart the next day (#1918) and missed the same two lists. Because the umbrella chart's appVersion computation already reads this file (line ~1345, unaffected), the chart still "worked" on any release that also rebuilt identity-resolution in the same CI run — the bump landed in the workspace and got packaged, just never persisted to main. The first release afterward that didn't touch identity-resolution's source packaged whatever was last committed: the original "0.0.0-dev" placeholder, which isn't a real GHCR tag. On dev (where identityResolution.deploy is now true post-cutover), that rendered an unpullable image, the migrate initContainer got stuck in ImagePullBackOff, and the umbrella upgrade failed on its progress deadline and auto-rolled back — repeatedly, since nothing fixed the root cause between attempts. One-time restore: set appVersion back to the last known-good tag (2026.07.25.07.16-a122f77 — verified currently running on dev) so the next release packages an existing image instead of the placeholder. Signed-off-by: Sergei Mozhaev <mozhaev.dev@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe chart publishing workflow now stages the identity-resolution Helm chart in both version-persistence commits. Its ChangesIdentity-resolution chart version persistence
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mitasovr
approved these changes
Jul 27, 2026
cyberantonz
approved these changes
Jul 27, 2026
mozhaev-dev
enabled auto-merge
July 27, 2026 08:50
2 tasks
cyberantonz
pushed a commit
to cyberantonz/insight
that referenced
this pull request
Jul 27, 2026
publish-chart's if-condition OR-list (the umbrella republish + appVersion-commit gate) checked analytics/authenticator/gateway/ identity/toolbox/umbrella but never identity_resolution. A merge that touches only identity-resolution's source (or, as just happened in constructorfabric#1939, only its Chart.yaml/workflow wiring) rebuilds the image (backend-identity-resolution + merge-identity-resolution both run) but publish-chart never fires — so the fresh appVersion bump is computed in the run's workspace and then silently dropped, same end result as the two hardcoded git-add lists constructorfabric#1939 just fixed, via a different mechanism (the job never runs at all here, instead of running and failing to persist). Caught by re-checking build-images.yml run 30255126297 (triggered by constructorfabric#1939 itself): backend-identity-resolution/merge-identity-resolution succeeded, but bump-descriptors and publish-chart both show up `skipped` — the exact blind spot this commit closes. Signed-off-by: Sergei Mozhaev <mozhaev.dev@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bump-descriptorsand the final "commit version bumps back to main" step inbuild-images.ymlstaged a hardcoded list of backend subchartChart.yamlfiles that never includedsrc/backend/services/identity-resolution/helm/Chart.yaml.bump-service-appversions.shbumps it correctly in the run's workspace, but since it was nevergit add-ed, the bump was silently discarded on every run. ci: persist authenticator/gateway appVersions + bump on manual rebuild #1890 fixed the identical gap forauthenticator/gatewaythree days earlier;identity-resolutionlanded as a subchart the next day (feat(identity-resolution): cutover readiness — parity fixes, side-by-side deploy, schema ownership (#1602) #1918) and missed the same two lists.main). The first release afterward that didn't touch identity-resolution's source packaged whatever was last committed — the original"0.0.0-dev"placeholder, not a real GHCR tag.identityResolution.deploy: truepost-cutover), that rendered an unpullable image; themigrateinitContainer got stuck inImagePullBackOff, the umbrella upgrade hit its progress deadline, and Helm auto-rolled back — repeatedly, since nothing fixed the root cause between attempts.appVersionset back to2026.07.25.07.16-a122f77— verified currently running on dev — so the next release packages an existing image instead of the placeholder.Test plan
yamllint/actionlintonbuild-images.yml(no syntax break — validated locally withyaml.safe_load)mainshould commit a realappVersionbump foridentity-resolutionback tomainwhenever its image is rebuiltSummary by CodeRabbit
Bug Fixes
Chores