Skip to content

fix(ci): publish-chart missing the workflow_dispatch full-rebuild fallback - #1947

Closed
mozhaev-dev wants to merge 2 commits into
mainfrom
fix/publish-chart-workflow-dispatch-fallback
Closed

fix(ci): publish-chart missing the workflow_dispatch full-rebuild fallback#1947
mozhaev-dev wants to merge 2 commits into
mainfrom
fix/publish-chart-workflow-dispatch-fallback

Conversation

@mozhaev-dev

Copy link
Copy Markdown
Contributor

Summary

  • Follow-up to fix(ci): persist identity-resolution appVersion bumps back to main #1939/fix(ci): trigger publish-chart when only identity-resolution changed #1943. Every per-service build job (e.g. backend-identity-resolution) triggers on needs.changes.outputs.<service> == 'true' || (github.event_name == 'workflow_dispatch' && inputs.frontend_tag == '') — a manual full-rebuild dispatch (empty frontend_tag) rebuilds every image regardless of what paths-filter detected changed.
  • publish-chart's own OR-list only checked the changes.outputs.* flags plus inputs.frontend_tag != '' — it had no equivalent full-rebuild fallback. So a manual workflow_dispatch would rebuild every backend image but never actually publish the umbrella chart bundling them.
  • Found while trying to verify fix(ci): trigger publish-chart when only identity-resolution changed #1943 (the identity_resolution flag missing from this same OR-list) without waiting for an unrelated merge to naturally touch identity-resolution/analytics/etc — a manual full-rebuild dispatch seemed like the obvious way to trigger it now, until this gap turned up too.

Test plan

  • YAML validated locally (yaml.safe_load)
  • A manual workflow_dispatch (empty frontend_tag) should now actually run publish-chart and publish a fresh umbrella chart

…lback

Every per-service build job (backend-identity-resolution and its
siblings) triggers on
  needs.changes.outputs.<service> == 'true'
  || (github.event_name == 'workflow_dispatch' && inputs.frontend_tag == '')
so a manual full-rebuild dispatch (empty frontend_tag) rebuilds every
image regardless of what paths-filter detected changed. publish-chart's
own OR-list only checked the changes.outputs.* flags plus
`inputs.frontend_tag != ''` — it had no equivalent full-rebuild
fallback, so a manual workflow_dispatch would rebuild every backend
image but never actually publish the umbrella chart that bundles them.

Found while trying to verify #1943 (the identity_resolution flag was
missing from this same OR-list) without waiting for an unrelated merge
to naturally touch identity-resolution/analytics/etc — a manual
full-rebuild dispatch seemed like the obvious way to trigger it now,
until this gap turned up too.

Signed-off-by: Sergei Mozhaev <mozhaev.dev@gmail.com>
@mozhaev-dev
mozhaev-dev requested a review from a team as a code owner July 27, 2026 10:47
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mozhaev-dev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 361c2954-b07b-4a8f-9fba-96d901665493

📥 Commits

Reviewing files that changed from the base of the PR and between b0df73e and 6a83578.

📒 Files selected for processing (1)
  • .github/workflows/build-images.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publish-chart-workflow-dispatch-fallback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mozhaev-dev
mozhaev-dev enabled auto-merge July 27, 2026 10:50
|| needs.changes.outputs.toolbox == 'true'
|| needs.changes.outputs.umbrella == 'true'
|| inputs.frontend_tag != ''
|| (github.event_name == 'workflow_dispatch' && inputs.frontend_tag == '')

@cyberantonz cyberantonz Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is wrong approach. If the image was built, the lines 1196-1203 will work.
So, please wait, looks like you do something wrong.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to do better?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about it :) Maybe i do not understand clearly what are you trying to solve.

@mozhaev-dev
mozhaev-dev disabled auto-merge July 27, 2026 11:20
@cyberantonz

Copy link
Copy Markdown
Contributor

Let's drop this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants