fix(ci): publish-chart missing the workflow_dispatch full-rebuild fallback - #1947
fix(ci): publish-chart missing the workflow_dispatch full-rebuild fallback#1947mozhaev-dev wants to merge 2 commits into
Conversation
…lback Every per-service build job (backend-identity-resolution and its siblings) triggers on needs.changes.outputs.<service> == 'true' || (github.event_name == 'workflow_dispatch' && inputs.frontend_tag == '') so a manual full-rebuild dispatch (empty frontend_tag) rebuilds every image regardless of what paths-filter detected changed. publish-chart's own OR-list only checked the changes.outputs.* flags plus `inputs.frontend_tag != ''` — it had no equivalent full-rebuild fallback, so a manual workflow_dispatch would rebuild every backend image but never actually publish the umbrella chart that bundles them. Found while trying to verify #1943 (the identity_resolution flag was missing from this same OR-list) without waiting for an unrelated merge to naturally touch identity-resolution/analytics/etc — a manual full-rebuild dispatch seemed like the obvious way to trigger it now, until this gap turned up too. Signed-off-by: Sergei Mozhaev <mozhaev.dev@gmail.com>
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| || needs.changes.outputs.toolbox == 'true' | ||
| || needs.changes.outputs.umbrella == 'true' | ||
| || inputs.frontend_tag != '' | ||
| || (github.event_name == 'workflow_dispatch' && inputs.frontend_tag == '') |
There was a problem hiding this comment.
It is wrong approach. If the image was built, the lines 1196-1203 will work.
So, please wait, looks like you do something wrong.
There was a problem hiding this comment.
How to do better?
There was a problem hiding this comment.
Let's talk about it :) Maybe i do not understand clearly what are you trying to solve.
|
Let's drop this PR |
Summary
backend-identity-resolution) triggers onneeds.changes.outputs.<service> == 'true' || (github.event_name == 'workflow_dispatch' && inputs.frontend_tag == '')— a manual full-rebuild dispatch (emptyfrontend_tag) rebuilds every image regardless of whatpaths-filterdetected changed.publish-chart's own OR-list only checked thechanges.outputs.*flags plusinputs.frontend_tag != ''— it had no equivalent full-rebuild fallback. So a manualworkflow_dispatchwould rebuild every backend image but never actually publish the umbrella chart bundling them.identity_resolutionflag missing from this same OR-list) without waiting for an unrelated merge to naturally touch identity-resolution/analytics/etc — a manual full-rebuild dispatch seemed like the obvious way to trigger it now, until this gap turned up too.Test plan
yaml.safe_load)workflow_dispatch(emptyfrontend_tag) should now actually runpublish-chartand publish a fresh umbrella chart