Skip to content

ci: pin backend appVersions in bump-descriptors too (fix manual rebuild) - #1894

Merged
cyberantonz merged 1 commit into
constructorfabric:mainfrom
cyberantonz:fix/ci-pin-backend-appversions-in-bump-descriptors
Jul 24, 2026
Merged

ci: pin backend appVersions in bump-descriptors too (fix manual rebuild)#1894
cyberantonz merged 1 commit into
constructorfabric:mainfrom
cyberantonz:fix/ci-pin-backend-appversions-in-bump-descriptors

Conversation

@cyberantonz

@cyberantonz cyberantonz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Why #1890 wasn't enough

#1890 added the backend subchart appVersion bump + persistence, but only inside publish-chart. On a manual full rebuild (run 30071800363), bump-descriptors committed the connector bumps and publish-chart was skipped — its needs.bump-descriptors.outputs.committed != 'true' gate defers it to the re-triggered push run. So the backend bump never executed.

The re-triggered push run (from the connector-descriptor commit) doesn't see any backend source as changed, so backends aren't rebuilt or bumped there either. Net result: connectors bumped, backends not — exactly what was observed.

This affects every run where bump-descriptors commits: a manual full rebuild, or any push that changes a backend and a connector together.

Fix

  • Extract the per-service appVersion bump into scripts/bump-service-appversions.sh, shared by publish-chart and bump-descriptors so both pin the same set of services identically.
  • bump-descriptors now also bumps + stages the backend subchart Chart.yamls in its (re-triggering) commit. The follow-up push run then sees those backends as changed, rebuilds them, and publish-chart persists their tags (via the git-add from ci: persist authenticator/gateway appVersions + bump on manual rebuild #1890). Backends end pinned to an image that exists; connectors keep their bumps.

Flow after this change

Manual full rebuild (workflow_dispatch, no frontend_tag):

  1. All images build at tag T1; bump-descriptors patches connector descriptors and bumps all backend appVersions → one commit (no [skip ci]) → re-trigger.
  2. Re-triggered push run: toolbox rebuilds against patched descriptors, backends rebuild (their Chart.yaml changed), publish-chart runs and persists every backend appVersion + publishes the umbrella.

Backend-only push (unchanged): bump-descriptors is skipped (no connector), publish-chart bumps + persists directly (the #1890 path).

Trade-off

On the full-rebuild / combined-push paths the backends build a second time in the re-triggered run. Those events are infrequent (manual re-pin, or a PR touching both a backend and a connector), so the extra build is acceptable in exchange for a single canonical chart publish.

Refs #1583

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Improved release automation to keep backend service chart versions synchronized with built images.
    • Added consistent handling for targeted service builds and full rebuilds.
    • Streamlined chart version updates across publishing workflows.

constructorfabric#1890 added the backend subchart appVersion bump + persistence, but only in
publish-chart. On a manual full rebuild (or any run where a connector also
changed), bump-descriptors commits the connector bumps and publish-chart is
deferred to the re-triggered run via its `committed != 'true'` gate — so the
backend bump never ran and only connectors got new versions (observed on
run 30071800363).

- Extract the per-service appVersion bump into
  scripts/bump-service-appversions.sh, shared by publish-chart and
  bump-descriptors so both pin the same set identically.
- bump-descriptors now also bumps + stages the backend subchart Chart.yaml
  files in its (re-triggering) commit. The follow-up push run then rebuilds
  those backends and publish-chart persists their tags — backends end pinned
  to an image that exists, connectors keep their bumps.

Refs constructorfabric#1583

Signed-off-by: Anton Zelenov <antonz@constructor.tech>
@cyberantonz
cyberantonz requested a review from a team as a code owner July 24, 2026 06:39
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d8afe366-19a3-4ccb-8398-22553ed1783f

📥 Commits

Reviewing files that changed from the base of the PR and between 4e36dbb and f5ca800.

📒 Files selected for processing (2)
  • .github/workflows/build-images.yml
  • .github/workflows/scripts/bump-service-appversions.sh

📝 Walkthrough

Walkthrough

The image build workflow now shares a script for conditionally updating backend service Helm chart appVersion values. The descriptor job stages these updates with connector descriptor changes, while the chart publishing job reuses the same script.

Changes

Backend service appVersion bumping

Layer / File(s) Summary
Shared appVersion bump script
.github/workflows/scripts/bump-service-appversions.sh
Adds strict flag-driven updates for four backend service charts using BUILD_TAG, FULL_REBUILD, and per-service build flags.
Workflow integration and commit staging
.github/workflows/build-images.yml
Invokes the shared script from descriptor and chart publishing jobs and stages backend helm/Chart.yaml files in descriptor commits.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

  • constructorfabric/insight issue 1685 — Covers moving service appVersion bumping into the canonical descriptor workflow path and sharing the implementation.

Possibly related PRs

Suggested reviewers: mitasovr

Sequence Diagram(s)

sequenceDiagram
  participant BuildWorkflow
  participant BumpScript
  participant ServiceCharts
  participant GitCommit
  BuildWorkflow->>BumpScript: pass BUILD_TAG and service flags
  BumpScript->>ServiceCharts: update selected appVersion values
  BuildWorkflow->>GitCommit: stage Chart.yaml files
  GitCommit->>GitCommit: commit descriptor and chart changes
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: pinning backend appVersions in bump-descriptors to fix manual rebuild behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cyberantonz
cyberantonz enabled auto-merge (squash) July 24, 2026 06:44
@cyberantonz
cyberantonz merged commit 6a45eaa into constructorfabric:main Jul 24, 2026
27 checks passed
@cyberantonz
cyberantonz deleted the fix/ci-pin-backend-appversions-in-bump-descriptors branch July 24, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants