Skip to content

fix(ci): trigger publish-chart when only identity-resolution changed - #1943

Merged
mozhaev-dev merged 1 commit into
mainfrom
fix/identity-resolution-publish-trigger
Jul 27, 2026
Merged

fix(ci): trigger publish-chart when only identity-resolution changed#1943
mozhaev-dev merged 1 commit into
mainfrom
fix/identity-resolution-publish-trigger

Conversation

@mozhaev-dev

@mozhaev-dev mozhaev-dev commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Follow-up to fix(ci): persist identity-resolution appVersion bumps back to main #1939. publish-chart's if: condition gates on an OR-list of needs.changes.outputs.* flags (analytics/authenticator/gateway/identity/toolbox/umbrella) — identity_resolution was never in that list, even though it's the only backend service missing.
  • Consequence: a merge that touches only identity-resolution (source, Chart.yaml, or its own workflow wiring) rebuilds the image fine (backend-identity-resolution + merge-identity-resolution both run and succeed), but publish-chart never fires — so the umbrella chart is never republished and the freshly-bumped appVersion is never committed back to main. Same end symptom as the two hardcoded git add lists fix(ci): persist identity-resolution appVersion bumps back to main #1939 fixed, but via a different mechanism: the job doesn't run at all here, rather than running and dropping the file.
  • Caught by re-checking build-images.yml run 30255126297 — the run fix(ci): persist identity-resolution appVersion bumps back to main #1939 itself triggered: backend-identity-resolution/merge-identity-resolution succeeded, but bump-descriptors and publish-chart both show skipped.

Test plan

  • YAML validated locally (yaml.safe_load)
  • Next merge touching only identity-resolution should have publish-chart actually run and commit a real appVersion bump

Summary by CodeRabbit

  • Bug Fixes
    • Updated release automation so chart publishing proceeds when identity-resolution backend changes are detected.

publish-chart's if-condition OR-list (the umbrella republish +
appVersion-commit gate) checked analytics/authenticator/gateway/
identity/toolbox/umbrella but never identity_resolution. A merge that
touches only identity-resolution's source (or, as just happened in
#1939, only its Chart.yaml/workflow wiring) rebuilds the image
(backend-identity-resolution + merge-identity-resolution both run)
but publish-chart never fires — so the fresh appVersion bump is
computed in the run's workspace and then silently dropped, same
end result as the two hardcoded git-add lists #1939 just fixed, via
a different mechanism (the job never runs at all here, instead of
running and failing to persist).

Caught by re-checking build-images.yml run 30255126297 (triggered by
#1939 itself): backend-identity-resolution/merge-identity-resolution
succeeded, but bump-descriptors and publish-chart both show up
`skipped` — the exact blind spot this commit closes.

Signed-off-by: Sergei Mozhaev <mozhaev.dev@gmail.com>
@mozhaev-dev
mozhaev-dev requested a review from a team as a code owner July 27, 2026 10:05
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3bb6e507-2f82-4f13-aa4f-ac2f32a5c8bf

📥 Commits

Reviewing files that changed from the base of the PR and between 38dcb05 and 0b00615.

📒 Files selected for processing (1)
  • .github/workflows/build-images.yml

📝 Walkthrough

Walkthrough

The publish-chart job condition now includes the identity_resolution change output, allowing chart publication when only the identity-resolution backend changes.

Changes

Chart publishing workflow

Layer / File(s) Summary
Extend chart publish gating
.github/workflows/build-images.yml
The publish-chart job now treats needs.changes.outputs.identity_resolution == 'true' as an allowed trigger.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: dzarlax

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main CI change to publish-chart behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/identity-resolution-publish-trigger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mozhaev-dev
mozhaev-dev merged commit b28b4d1 into main Jul 27, 2026
33 checks passed
cyberantonz added a commit that referenced this pull request Jul 27, 2026
…ests (#1949)

Since identity-resolution publishing landed (#1943), every run building
BOTH images fails merge-identity: its download-artifact pattern
'digests-identity-*' also matches 'digests-identity-resolution-*', and
imagetools create then references the foreign digests under the
insight-identity name -- 'not found' (runs 30264529022, 30269317477).

Pin the pattern to 'digests-identity-{amd64,arm64}'. No other artifact
prefixes collide. Bump the identity Dockerfile rebuild marker so this
merge triggers a scoped identity build that republishes the image and
advances the chart pin.

Signed-off-by: Anton Zelenov <antonz@constructor.tech>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants