fix(ci): trigger publish-chart when only identity-resolution changed - #1943
Merged
Conversation
publish-chart's if-condition OR-list (the umbrella republish + appVersion-commit gate) checked analytics/authenticator/gateway/ identity/toolbox/umbrella but never identity_resolution. A merge that touches only identity-resolution's source (or, as just happened in #1939, only its Chart.yaml/workflow wiring) rebuilds the image (backend-identity-resolution + merge-identity-resolution both run) but publish-chart never fires — so the fresh appVersion bump is computed in the run's workspace and then silently dropped, same end result as the two hardcoded git-add lists #1939 just fixed, via a different mechanism (the job never runs at all here, instead of running and failing to persist). Caught by re-checking build-images.yml run 30255126297 (triggered by #1939 itself): backend-identity-resolution/merge-identity-resolution succeeded, but bump-descriptors and publish-chart both show up `skipped` — the exact blind spot this commit closes. Signed-off-by: Sergei Mozhaev <mozhaev.dev@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesChart publishing workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ktursunov
approved these changes
Jul 27, 2026
mitasovr
approved these changes
Jul 27, 2026
2 tasks
cyberantonz
added a commit
that referenced
this pull request
Jul 27, 2026
…ests (#1949) Since identity-resolution publishing landed (#1943), every run building BOTH images fails merge-identity: its download-artifact pattern 'digests-identity-*' also matches 'digests-identity-resolution-*', and imagetools create then references the foreign digests under the insight-identity name -- 'not found' (runs 30264529022, 30269317477). Pin the pattern to 'digests-identity-{amd64,arm64}'. No other artifact prefixes collide. Bump the identity Dockerfile rebuild marker so this merge triggers a scoped identity build that republishes the image and advances the chart pin. Signed-off-by: Anton Zelenov <antonz@constructor.tech> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-chart'sif:condition gates on an OR-list ofneeds.changes.outputs.*flags (analytics/authenticator/gateway/identity/toolbox/umbrella) —identity_resolutionwas never in that list, even though it's the only backend service missing.backend-identity-resolution+merge-identity-resolutionboth run and succeed), butpublish-chartnever fires — so the umbrella chart is never republished and the freshly-bumped appVersion is never committed back tomain. Same end symptom as the two hardcodedgit addlists fix(ci): persist identity-resolution appVersion bumps back to main #1939 fixed, but via a different mechanism: the job doesn't run at all here, rather than running and dropping the file.build-images.ymlrun 30255126297 — the run fix(ci): persist identity-resolution appVersion bumps back to main #1939 itself triggered:backend-identity-resolution/merge-identity-resolutionsucceeded, butbump-descriptorsandpublish-chartboth showskipped.Test plan
yaml.safe_load)identity-resolutionshould havepublish-chartactually run and commit a real appVersion bumpSummary by CodeRabbit