Skip to content

lld v13.0.1 (again)#34

Merged
isuruf merged 9 commits into
conda-forge:masterfrom
h-vetinari:rebased
Feb 28, 2022
Merged

lld v13.0.1 (again)#34
isuruf merged 9 commits into
conda-forge:masterfrom
h-vetinari:rebased

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Feb 22, 2022

Copy link
Copy Markdown
Member

Rebased #33 to keep CI results for reference if we still need to fix something.

Closes #33
Closes #32
Closes #31
Closes #30
Closes #29

Closes conda-forge/staged-recipes#18004

@h-vetinari h-vetinari requested a review from isuruf as a code owner February 22, 2022 13:27
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

OK, this is still failing despite the llvm build having LLVM_ENABLE_LIBXAR=OFF as well. I went and raised an issue: llvm/llvm-project#54001

@h-vetinari

Copy link
Copy Markdown
Member Author

Woohoo, a passing osx build 🥳

Now that the setting has taken effect in llvmdev, let's see if we can avoid it here. Together with the also-finally-passing conda-forge/libcxx-feedstock#83, this should be bringing up the last relevant bits and pieces for LLVM 13 in conda-forge 🚀

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @conda-forge/lld

This is green and ready :)

@h-vetinari

Copy link
Copy Markdown
Member Author

Gentle ping @isuruf

Comment thread recipe/meta.yaml Outdated
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@h-vetinari

Copy link
Copy Markdown
Member Author

OK cool, looks like this worked! :)

Let me know if you want me to clean up the commit message / history, otherwise this is ready.

@isuruf

isuruf commented Feb 28, 2022

Copy link
Copy Markdown
Member

Thanks

@isuruf isuruf merged commit 1da932a into conda-forge:master Feb 28, 2022
@h-vetinari h-vetinari deleted the rebased branch February 28, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants