Skip to content

libcxx v13.0.1 (redux)#83

Merged
isuruf merged 11 commits into
conda-forge:masterfrom
h-vetinari:13.0.1
Mar 12, 2022
Merged

libcxx v13.0.1 (redux)#83
isuruf merged 11 commits into
conda-forge:masterfrom
h-vetinari:13.0.1

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Feb 5, 2022

Copy link
Copy Markdown
Member

Rebases #80 against master

Closes #82
Closes #80
Closes #79

@conda-forge-linter

conda-forge-linter commented Feb 5, 2022

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

h-vetinari commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

Waiting for builds from conda-forge/clangdev-feedstock#163

@h-vetinari h-vetinari mentioned this pull request Feb 5, 2022
Merged
@h-vetinari h-vetinari closed this Feb 6, 2022
@h-vetinari h-vetinari reopened this Feb 6, 2022
@h-vetinari h-vetinari closed this Feb 6, 2022
@h-vetinari h-vetinari reopened this Feb 6, 2022
@h-vetinari h-vetinari force-pushed the 13.0.1 branch 3 times, most recently from 434e62a to eadb6ed Compare February 6, 2022 05:19
@h-vetinari

h-vetinari commented Feb 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Unfortunately, the comment from the PR for 13.0.0 is still relevant - it keeps failing while trying to find #include <__config_site>, even when setting LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as mentioned in https://reviews.llvm.org/D97572.

The upstream build system was reshuffled a fair bit, so it's possible that what this feedstock is doing is currently broken, and maybe considered unsupported by upstream. Certainly, the docs for building libcxx look very different than what we're doing, so I'm a bit at a loss on how to fix it.

I can raise an issue upstream, but first wanted to hear if someone from @conda-forge/libcxx has a better idea what's going on.

PS. While trying to fix the failure, I switched the include paths from include/c++/v1 (the current default) to include (at least, I think we want unversioned include paths...), see eadb6ed

@h-vetinari

This comment was marked as outdated.

Sign in to view
@h-vetinari

This comment was marked as outdated.

Sign in to view
@h-vetinari

h-vetinari commented Feb 23, 2022

Copy link
Copy Markdown
Member Author

OK, chasing down __config_site a bit more, it get's generated here, relative to LIBCXX_GENERATED_INCLUDE_TARGET_DIR, which gets set here (for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF).

This made me finally understand why the recipe was failing... Fixed now. 🥳

@h-vetinari

h-vetinari commented Feb 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@conda-forge/libcxx
This is now finally ready after having one crucial lightbulb go on (see d212617).

@h-vetinari h-vetinari mentioned this pull request Feb 23, 2022
Merged
@h-vetinari

h-vetinari commented Feb 28, 2022

Copy link
Copy Markdown
Member Author

@conda-forge/libcxx
I think this should be the last missing piece before we can activate llvm 13 in conda-forge. Could you PTAL?

xhochy
xhochy reviewed Mar 4, 2022
View reviewed changes
Comment thread recipe/conda_build_config.yaml
@h-vetinari

h-vetinari commented Mar 7, 2022

Copy link
Copy Markdown
Member Author

Gentle ping @conda-forge/libcxx

xhochy
xhochy approved these changes Mar 7, 2022
View reviewed changes

@xhochy xhochy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm not a maintainer here, so someone else should press the button.

@h-vetinari

h-vetinari commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

Another very gentle ping @conda-forge/libcxx (I'd be joining as maintainer - then I could also stop pinging for routine tasks)

@isuruf isuruf merged commit d1d9f46 into conda-forge:master Mar 12, 2022
@isuruf

isuruf commented Mar 12, 2022

Copy link
Copy Markdown
Member

Thanks

@h-vetinari h-vetinari deleted the 13.0.1 branch March 12, 2022 23:10
@h-vetinari h-vetinari mentioned this pull request Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochy xhochy xhochy approved these changes

@beckermr beckermr Awaiting requested review from beckermr

@inducer inducer Awaiting requested review from inducer

@isuruf isuruf Awaiting requested review from isuruf

@jakirkham jakirkham Awaiting requested review from jakirkham

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay

@timsnyder timsnyder Awaiting requested review from timsnyder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@h-vetinari @conda-forge-linter @isuruf @xhochy @regro-cf-autotick-bot