Skip to content

lld v13.0.1 (redux)#33

Closed
h-vetinari wants to merge 19 commits into
conda-forge:masterfrom
h-vetinari:13.0.1
Closed

lld v13.0.1 (redux)#33
h-vetinari wants to merge 19 commits into
conda-forge:masterfrom
h-vetinari:13.0.1

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

Rebased #31 against master

Closes #32 (hopefully)
Closes #31
Closes #30
Closes #29

@h-vetinari h-vetinari requested a review from isuruf as a code owner February 4, 2022 13:16
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Waiting for builds from conda-forge/llvmdev-feedstock#140 (CI didn't trigger on merge)

@h-vetinari h-vetinari closed this Feb 5, 2022
@h-vetinari h-vetinari reopened this Feb 5, 2022
@h-vetinari

h-vetinari commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

Note, this PR still has some debug commits and should probably not be merged as-is.

  • Luckily, the windows failure from Build 13.0.1-rc's #31 is gone (so we can revert 7c65576 and maybe also 81a871d) - fingers crossed that the rest of the build succeeds as well
  • For OSX, 6ae10da is worth noting as raising the minimum OSX SDK to 10.13. I tried in Build 13.0.1-rc's #31 to avoid that, but without success. Here's a summary:

    I think the xar issues (same as in lld v13.0.0 (redux) #30) might be due to a recent addition. In any case, they fail with MACOS_SDK 10.12 (despite LLVM_HAVE_LIBXAR), but pass with 10.13 & 10.14.

    It's also worth noting that xar has been deprecated since MACOSX_SDK 12.0, and upstream warns since LLVM 14 that LLVM_HAVE_LIBXAR might be removed in the future.

@h-vetinari

Copy link
Copy Markdown
Member Author

Alright, this is ready except for a clean-up of the commit history. The one outstanding question is that it requires bumping MACOSX_DEPLOYMENT_TARGET to 10.13 - below that there are errors with xar symbols that I couldn't solve, even with LLVM_HAVE_LIBXAR (see previous comment).

CC @conda-forge/lld

@isuruf

isuruf commented Feb 9, 2022

Copy link
Copy Markdown
Member

I think we should build libxar ourselves.

@h-vetinari

Copy link
Copy Markdown
Member Author

I think we should build libxar ourselves.

Seems the original project has been very dead for a while; curiously this fork has continued with minting new releases a bit longer, but even the last release is close to 10 years old. Which one do you prefer?

This is to support MACOSX_DEPLOYMENT_TARGET 10.9 - 10.12, right? I.e. not necessary anywhere else? I can try to see if it builds for osx-64...

@isuruf

isuruf commented Feb 9, 2022

Copy link
Copy Markdown
Member

I was thinking of the sources from apple at https://opensource.apple.com/tarballs/xar/

@isuruf

isuruf commented Feb 9, 2022

Copy link
Copy Markdown
Member

This is to support MACOSX_DEPLOYMENT_TARGET 10.9 - 10.12, right? I.e. not necessary anywhere else? I can try to see if it builds for osx-64...

Yes, and also for linux I guess.

@h-vetinari

Copy link
Copy Markdown
Member Author

I was thinking of the sources from apple at https://opensource.apple.com/tarballs/xar/

OK. Which version to start with? Will we need to build an old version to be (ABI-?)compatible with the libxar that's in the old SDKs? Wouldn't the fact that it's part of those SDKs potentially mean migrating every osx-package against libxar?

@isuruf

isuruf commented Feb 9, 2022

Copy link
Copy Markdown
Member

Latest would be fine. I don't think there'd be any ABI compatibility issues and I doubt there are other packages using it.

@isuruf isuruf closed this in #34 Feb 28, 2022
@h-vetinari h-vetinari deleted the 13.0.1 branch February 28, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants