Skip to content

WIP: package libxar#18004

Closed
h-vetinari wants to merge 10 commits into
conda-forge:mainfrom
h-vetinari:libxar
Closed

WIP: package libxar#18004
h-vetinari wants to merge 10 commits into
conda-forge:mainfrom
h-vetinari:libxar

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

Requested by Isuru here. Not 100% convinced myself, but want to unblock LLVM work.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libxar) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

@isuruf, I'm not sure why the CommonCrypto headers aren't found.

+ make
x86_64-apple-darwin13.4.0-clang -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/libxar-1.8 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix  -fPIC -DPIC -dynamic -Iinclude -Iinclude -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=10.9 -I/Users/runner/mambaforge/include/libxml2 -I/Users/runner/mambaforge/include -c lib/archive.c -o lib/archive.o
In file included from lib/archive.c:64:
lib/archive.h:45:10: fatal error: 'CommonCrypto/CommonDigestSPI.h' file not found
#include <CommonCrypto/CommonDigestSPI.h>

Can't find another usable example in conda-forge either. Sidenote: even the offical xar from apple doesn't build against our macos sdk anymore...

Linux fails with some openssl issue. Presumably xar was built against an openssl that was quite a bit older (1.0.2?). I also think we should skip linux and just do the minimum to unblock lld on osx.

PS. I added you as a maintainer on this, because you suggested to build it in the first place, and I don't think I can reasonably maintain it by myself.

@xhochy

xhochy commented Feb 18, 2022

Copy link
Copy Markdown
Member

CommonDigestSPI.h has been part of the SDK quite a while ago. It should be in $SDKROOT/usr/include/CommonCrypto but I don't see it in any of the SDK we support in conda-forge.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dimod, recipes/drm4g, recipes/openfermionpyscf, recipes/pennylane-qchem, recipes/sphinx-reredirects, recipes/ssort) and found some lint.

Here's what I've got...

For recipes/dimod:

  • Feedstock with the same name exists in conda-forge.

For recipes/drm4g:

  • Feedstock with the same name exists in conda-forge.

For recipes/openfermionpyscf:

  • Feedstock with the same name exists in conda-forge.

For recipes/pennylane-qchem:

  • Feedstock with the same name exists in conda-forge.

For recipes/sphinx-reredirects:

  • Feedstock with the same name exists in conda-forge.

For recipes/ssort:

  • Feedstock with the same name exists in conda-forge.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libxar) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Well, thrashing around a bit with the MacOS versions as well as newer/older libxar, it always ends up with a missing #include <CommonCrypto/CommonDigestSPI.h>.

Looking at the sources in question, it seems like we might be able to replace them with an include from openssl. Would that be a good idea...?

@isuruf

isuruf commented Feb 19, 2022

Copy link
Copy Markdown
Member

If it's too much trouble, we can drop this. It looks like xar format is an old deprecated format.

@h-vetinari

Copy link
Copy Markdown
Member Author

If it's too much trouble, we can drop this. It looks like xar format is an old deprecated format.

I'd be in favour to be honest. It would mean bumping the minimum for lld to 10.13, but then 10.12 has been EOL for almost 2.5 years already. Are we willing to swallow that?

@isuruf

isuruf commented Feb 19, 2022

Copy link
Copy Markdown
Member

It's not required AFAIK

@h-vetinari

Copy link
Copy Markdown
Member Author

It's not required AFAIK

I tried both -DLLVM_HAVE_LIBXAR=0 and -DLLVM_ENABLE_LIBXAR=OFF in conda-forge/lld-feedstock#33 without success. Not sure how else to switch it off...

@isuruf

isuruf commented Feb 21, 2022

Copy link
Copy Markdown
Member

lld probably uses the setting from llvm. We'll have to turn it off in llvmdev-feedstock

@h-vetinari

Copy link
Copy Markdown
Member Author

lld probably uses the setting from llvm. We'll have to turn it off in llvmdev-feedstock

OK: conda-forge/llvmdev-feedstock#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants