Support CUDA 12 by conda-forge-admin · Pull Request #199 · conda-forge/cupy-feedstock

conda-forge-admin · 2023-04-18T02:36:11Z

Close #139. Close #143.

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #198.

Here's a checklist to do before merging.

Bump the build number if needed.

Fixes #198

conda-forge-webservices · 2023-04-18T02:36:17Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

…nda-forge-pinning 2023.04.18.01.55.25

disable aarch64/ppc64le for now

…nda-forge-pinning 2023.04.18.01.55.25

Co-authored-by: jakirkham <jakirkham@gmail.com>

github-actions · 2023-05-31T18:15:16Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cupy-feedstock/actions/runs/5136254960.

recipe/conda_build_config.yaml

As this appears to no longer be needed, try dropping it.

jakirkham · 2023-05-31T20:17:52Z

@conda-forge-admin, please re-render

…nda-forge-pinning 2023.05.31.19.00.54

Looks like VS2019 still doesn't work here. So readd the `conda_build_config.yaml` with a configuration to use VS2017 on Windows again.

jakirkham · 2023-05-31T21:23:28Z

@conda-forge-admin, please re-render

…nda-forge-pinning 2023.05.31.19.00.54

leofang · 2023-06-01T16:51:55Z

Thanks, John, let's merge. I noticed one of the ppc64le CIs started hitting error since yesterday. I hope it's just a transient issue. Will monitor & retry on master.

leofang · 2023-06-01T16:55:58Z

btw I deleted the cuda-11 branch since it's no longer needed. With this PR the master recipe has all needed support (cross compiling & CUDA 12).

leofang · 2023-06-01T16:56:55Z

@kmaehashi To reduce potential conflicts, would it be OK if I upstream the patch I wrote here? It should be no-op for normal users, and only triggered in a conda-build environment.

jakirkham · 2023-06-01T18:59:43Z

Thanks Leo! 🙏

leofang · 2023-06-01T19:44:37Z

Travis is misbehaving again... (no output in 10 mins) Will switch back to cross compiling.

leofang · 2023-06-01T19:56:05Z

Travis is misbehaving again... (no output in 10 mins) Will switch back to cross compiling.

See #202.

jakirkham · 2023-06-01T20:34:00Z

FWIW tried a new Travis build to see if it was a fluke. Though happy to go with cross-compilation

leofang · 2023-06-01T20:36:27Z

Oh I already retried twice, sorry I forgot to mention.

jakirkham · 2023-06-01T20:44:21Z

Ah ok. Yeah cross-compilation seems like the right solution then

kmaehashi · 2023-06-02T01:29:58Z

@kmaehashi To reduce potential conflicts, would it be OK if I upstream the patch I wrote here? It should be no-op for normal users, and only triggered in a conda-build environment.

Yes of course 😄
Thanks so much for the hard work on maintaining the package!

leofang · 2023-06-02T03:55:44Z

Yes of course 😄
Thanks so much for the hard work on maintaining the package!

Sent a PR: cupy/cupy#7603 🙂

jakirkham · 2023-06-02T19:12:10Z

recipe/meta.yaml

+    # TODO: see https://github.com/conda-forge/cudnn-feedstock/issues/58
+    - cudnn >=8           # [not ((aarch64 or ppc64le) and cuda_compiler_version == "12.0")]
+    # TODO: wait for NCCL to catch up
+    - nccl >=2.8          # [linux and cuda_compiler_version != "12.0"]
+    - cutensor >=1.4,<2
+    - cusparselt 0.2.0.*  # [(linux64 or win) and cuda_compiler_version == "11.2"]


Wonder if we can drop some of these selectors now that these packages have been rebuilt

Edit: Filed as issue ( #207 )

dummy commit for rerendering

3f32ed5

conda-forge-admin requested review from asi1024, emcastillo, jakirkham, kmaehashi, leofang and toslunar as code owners April 18, 2023 02:36

conda-forge-webservices bot mentioned this pull request Apr 18, 2023

@conda-forge-admin, please rerender #198

Closed

leofang changed the title ~~MNT: rerender~~ WIP: Support CUDA 12 Apr 18, 2023

MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…

e7911f2

…nda-forge-pinning 2023.04.18.01.55.25

leofang mentioned this pull request Apr 18, 2023

Switch to cross-compilation for aarch64/ppc64le #197

Merged

1 task

leofang added 4 commits April 17, 2023 22:45

Update conda-forge.yml

d69adef

disable aarch64/ppc64le for now

Delete cuda_112_ppc64le_aarch64.yaml

42d4945

Update conda_build_config.yaml

bd65c04

Update meta.yaml

6723720

This comment was marked as resolved.

Sign in to view

leofang marked this pull request as draft April 18, 2023 02:57

conda-forge-webservices[bot] and others added 3 commits April 18, 2023 02:59

MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…

f489df6

…nda-forge-pinning 2023.04.18.01.55.25

find nvcc

7fb73fd

patch the build system for the new layout

7ac0e14

leofang mentioned this pull request Apr 18, 2023

[DO NOT MERGE] Test NVIDIA's official CUDA packages #143

Closed

5 tasks

leofang added 4 commits April 17, 2023 20:55

fix missing nvrtc header

5b0baf5

add driver stub

36700b3

fix stub path, again

4647d8c

fix stub path, again

3f3b6e0

This comment was marked as outdated.

Sign in to view

leofang mentioned this pull request Apr 18, 2023

Headers are only in $PREFIX/targets folder but aren't in $PREFIX/include conda-forge/libcublas-feedstock#11

Closed

1 task

This comment was marked as resolved.

Sign in to view

add missing nvtx

fe403ef

Co-authored-by: jakirkham <jakirkham@gmail.com>

jakirkham reviewed May 31, 2023

View reviewed changes

recipe/conda_build_config.yaml Outdated Show resolved Hide resolved

Drop conda_build_config.yaml

e42df31

As this appears to no longer be needed, try dropping it.

conda-forge-webservices[bot] and others added 2 commits May 31, 2023 20:21

MNT: Re-rendered with conda-build 3.25.0, conda-smithy 3.23.1, and co…

b761a06

…nda-forge-pinning 2023.05.31.19.00.54

Configure using VS2017 on Windows again

15ab482

Looks like VS2019 still doesn't work here. So readd the `conda_build_config.yaml` with a configuration to use VS2017 on Windows again.

MNT: Re-rendered with conda-build 3.25.0, conda-smithy 3.23.1, and co…

b44747b

…nda-forge-pinning 2023.05.31.19.00.54

leofang merged commit b1c034f into conda-forge:main Jun 1, 2023

This was referenced Jun 2, 2023

Support CUDA 12 + aarch64 #203

Closed

Support CUDA 12 + ppc64le #204

Closed

Support CUDA 12 + Windows #205

Closed

This was referenced Jun 2, 2023

Rebuild for cuda for ppc64le and aarch64 conda-forge/faiss-split-feedstock#62

Closed

Rebuild for CUDA 12 conda-forge/cudasirecon-feedstock#16

Merged

leofang mentioned this pull request Jun 2, 2023

Patch the build system to better support conda-build cupy/cupy#7603

Merged

jakirkham reviewed Jun 2, 2023

View reviewed changes

This was referenced Jun 2, 2023

Adding optional dependencies on CUDA 12 #207

Closed

Use Visual Studio 2019 for CUDA 11.x conda-forge/conda-smithy#1738

Closed

leofang mentioned this pull request Aug 22, 2024

@conda-forge-admin, please rerender #279

Closed

Uh oh!

Conversation

conda-forge-admin commented Apr 18, 2023 • edited by leofang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-webservices bot commented Apr 18, 2023

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

Uh oh!

github-actions bot commented May 31, 2023

Uh oh!

Uh oh!

jakirkham commented May 31, 2023

Uh oh!

jakirkham commented May 31, 2023

Uh oh!

leofang commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leofang commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leofang commented Jun 1, 2023

Uh oh!

jakirkham commented Jun 1, 2023

Uh oh!

leofang commented Jun 1, 2023

Uh oh!

leofang commented Jun 1, 2023

Uh oh!

jakirkham commented Jun 1, 2023

Uh oh!

leofang commented Jun 1, 2023

Uh oh!

jakirkham commented Jun 1, 2023

Uh oh!

kmaehashi commented Jun 2, 2023

Uh oh!

leofang commented Jun 2, 2023

Uh oh!

jakirkham Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

conda-forge-admin commented Apr 18, 2023 •

edited by leofang

Loading

leofang commented Jun 1, 2023 •

edited

Loading

leofang commented Jun 1, 2023 •

edited

Loading

jakirkham Jun 2, 2023 •

edited

Loading