Patch the build system to better support conda-build#7603
Merged
Patch the build system to better support conda-build#7603
Conversation
1 task
kmaehashi
reviewed
Jun 5, 2023
Member
Author
|
/test mini |
Member
Author
|
/test mini |
Member
Author
|
FYI @kmaehashi this is ready 🙂 |
8 tasks
Member
Author
|
Update: I updated the PR with Windows support (from conda-forge/cupy-feedstock#228). If we plan to backport this PR, I can do it manually (the CUB path lookup needs to be patched). |
Member
Author
|
/test mini |
Member
Author
|
/test mini |
Member
Author
|
@kmaehashi Shall we try to get this merged (and backported) before the next release, so that we can avoid maintaining the patch in cupy-feedstock? |
3 tasks
Member
Author
|
Hi @kmaehashi any chance we can get this PR merged and backported to v13.2.0? It's getting more and more challenging for me to maintain a big patch for conda-forge... 😅 |
Member
Author
|
/test mini |
Member
|
/test mini (to include now required CUDA 12.5 checks) |
kmaehashi
approved these changes
Aug 8, 2024
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Aug 8, 2024
Patch the build system to better support conda-build
jakirkham
added a commit
to conda-forge-admin/cupy-feedstock
that referenced
this pull request
Aug 22, 2024
jakirkham
added a commit
to conda-forge-admin/cupy-feedstock
that referenced
this pull request
Aug 22, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch taken from conda-forge/cupy-feedstock#199.
Context:
build_shlib()andbuild_and_run()) that essentially checks the dependencies on the build platform (say linux64), but the actual binaries on the target platform (say aarch64) cannot be linked by the cross compiler (on linux64). A linker failure is raised when attempting to do so.Approach:
This patch has not been validated on Windows yet, becauseIt makes little sense to cross compile from linux64 to win64CUDA 12 + win64 is not supported yetAlso close #8124.