Skip to content

[DO NOT MERGE] Test NVIDIA's official CUDA packages#143

Closed
leofang wants to merge 18 commits intoconda-forge:mainfrom
leofang:nvidia_cuda
Closed

[DO NOT MERGE] Test NVIDIA's official CUDA packages#143
leofang wants to merge 18 commits intoconda-forge:mainfrom
leofang:nvidia_cuda

Conversation

@leofang
Copy link
Copy Markdown
Member

@leofang leofang commented Aug 16, 2021 •
edited
Loading

Close #139.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@leofang
try using nvidia's cuda packages
25c8cdb 
MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.12, and conda-forge-pinning 2021.08.14.10.30.44
@conda-forge-linter
Copy link
Copy Markdown

conda-forge-linter commented Aug 16, 2021

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Aug 16, 2021

@conda-forge-admin, please rerender

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Aug 17, 2021

Missing crt/host_defines.h:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=364599&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642&l=205
Reported in conda-forge/cudatoolkit-feedstock#62 (comment).

leofang added 4 commits August 19, 2021 22:23
@leofang
try restoring cuda_compiler
439d54b 
MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.12, and conda-forge-pinning 2021.08.19.19.17.07
@leofang
disable ppc64le; add cuda-nvcc to host
5388fa9 
MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.12, and conda-forge-pinning 2021.08.19.19.17.07
@leofang
add thrust
a6be865
@leofang
specify host compiler on linux
86fefc2
@leofang
Copy link
Copy Markdown
Member Author

leofang commented Aug 20, 2021 •
edited
Loading

Tests passed on Linux64 and Windows.

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Aug 22, 2021

Darn it, I was fooled by the ongoing Azure issue. The feedstock status is not reported, so the green check only includes the linter's report...

This was referenced Aug 22, 2021
Closed
Closed
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Aug 27, 2021

FYI Azure status issue has been fixed

@leofang leofang mentioned this pull request Oct 1, 2021
Merged
5 tasks
jakirkham
jakirkham reviewed Apr 12, 2023
View reviewed changes
Comment thread recipe/meta.yaml
- cuda-nvcc # for crt/host_defines.h
- cuda-cudart
- cuda-nvrtc
- cuda-nvprof # for cuda_profiler_api.h
Copy link
Copy Markdown
Member

@jakirkham jakirkham Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have the cuda-profiler-api package, does that solve this need? Or are there other things that cuda-nvprof is still needed for?

Copy link
Copy Markdown
Member Author

@leofang leofang Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CuPy doesn't need the legacy nvprof (cmdline tool), just the profiler header.

@leofang leofang mentioned this pull request Apr 18, 2023
Merged
1 task
@leofang
Copy link
Copy Markdown
Member Author

leofang commented Apr 18, 2023

Would be superseded by #199.

@leofang leofang closed this in #199 Jun 1, 2023
@leofang leofang deleted the nvidia_cuda branch June 1, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham left review comments

@asi1024 asi1024 Awaiting requested review from asi1024 asi1024 will be requested when the pull request is marked ready for review asi1024 is a code owner

@emcastillo emcastillo Awaiting requested review from emcastillo emcastillo will be requested when the pull request is marked ready for review emcastillo is a code owner

@kmaehashi kmaehashi Awaiting requested review from kmaehashi kmaehashi will be requested when the pull request is marked ready for review kmaehashi is a code owner

@toslunar toslunar Awaiting requested review from toslunar toslunar will be requested when the pull request is marked ready for review toslunar is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CuPy: Support CUDA 12

3 participants

@leofang @conda-forge-linter @jakirkham