Skip to content

Rebuild for CUDA 12#16

Merged
tlambert03 merged 4 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-cuda120-0-1_ha09a9c
Jun 8, 2023
Merged

Rebuild for CUDA 12#16
tlambert03 merged 4 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-cuda120-0-1_ha09a9c

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5141416550, please use this URL for debugging.

@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Copy Markdown
Member

Seeing the following error on CI:

CUDA_cufft_LIBRARY (ADVANCED)
    linked by target "cudaSireconDriver" in directory /home/conda/feedstock_root/build_artifacts/cudasirecon_1685604929367/work/src/cudaSirecon
    linked by target "cudasirecon" in directory /home/conda/feedstock_root/build_artifacts/cudasirecon_1685604929367/work/src/cudaSirecon

As the new CUDA 12 packages split all these components up ( conda-forge/staged-recipes#21382 ), think we need to add libcufft-dev to host:

  host:
    - libcufft-dev      # [(cuda_compiler_version or "").startswith("12")]

Note that *-dev suffixed packages have headers and dynamic libraries. They add the * package (no -dev suffix) to run automatically via run_exports

Edit: For more info about the CUDA 12 bringup, please see issue ( conda-forge/conda-forge.github.io#1963 )

@jakirkham
Copy link
Copy Markdown
Member

Also regarding CUDA Windows builds, have seen some odd behavior with vs2019 and CUDA ( conda-forge/cupy-feedstock#199 (comment) ). Switching to vs2017 has helped. Maybe that would address the issue seen here?

@jakirkham
Copy link
Copy Markdown
Member

@conda-forge-admin , please restart CI

@jakirkham
Copy link
Copy Markdown
Member

Looks like this now passes! 🎉

@tlambert03
Copy link
Copy Markdown
Member

Wow! Awesome :) thanks

@tlambert03 tlambert03 merged commit c319d98 into conda-forge:main Jun 8, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-1_ha09a9c branch June 8, 2023 18:18
@jakirkham
Copy link
Copy Markdown
Member

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants