Update for CSI v0.3.0 Specification Changes #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule src/code.cloudfoundry.org/csishim 409becd0..bb675c6d: > Regenerate fakes for CSI v0.3.0 > switch connection to interface in NewControllerClient Submodule src/code.cloudfoundry.org/volman bb06b98..be44867: > Check for accessibility constraints when discovering CSI plugins Submodule src/github.com/container-storage-interface/spec 35d9f9d7..2178fdee: > Introduce concept of topology to CSI spec. > spec: Fix grammatical error > spec: Remove trailing spaces. > spec: Volume from snapshot with different size > spec: Fix SnapshotSource commment > spec: Add units for GetCapacityResponse > spec: clarify field requirements * fixes #185 > Merge pull request #221 from gnufied/add-node-capacity > spec: Probe, s/readiness/ready/ > spec: replace Readiness with WKT BoolValue > lib/go: initial support for protobuf "well known types" > spec: ProbeResponse reports readiness > spec: fix spelling > spec: consistently document intentionally empty messages > Merge pull request #224 from xing-yang/snapshot2 > Merge pull request #234 from jdef/pin_golang_protobuf_1.1.0 > lib/go: regenerate bindings w/ latest golang/protobuf generator > make: transitively clean/clobber generated go bindings > Merge pull request #223 from jdef/jdef_clarify_authoring_process > address review feedback > spec: use MUST when describing CapacityRange field reqs > lib: Fix the generated code for CI > spec: Some consistency fix on map declarations > spec: Remove a reference to VolumeInfo > travis: bump golang to 1.9.5 > Merge pull request #203 from jieyu/csi_adoption > gRPC error code corrections > Merge pull request #210 from saad-ali/bump020release Submodule src/github.com/golang/protobuf c3cefd437..b4deda097: > Merge pull request #591 from golang/master-merge > Fix godoc examples for Any (#569) > proto, protoc-gen-go: fix vet and gofmt errors for Go 1.10 (#508) > proto: add DiscardUnknown function (#498) > Revert "fix unnecessary rounding to float64 precision when JSON-marshaling durations (#453)" (#493) > fix unnecessary rounding to float64 precision when JSON-marshaling durations (#453) > Add godoc badge (#444) > jsonpb: fix unmarshal null to value that implements JSONPBUnmarshaler (#429) > update protos to 3.4.1 tag of google/protobuf repo (#428) > Fix interpretation of default bytes literal values (#427) > README: specify syntax in proto example. (#417) > jsonpb: add support for custom resolution of Any messages to/from JSON (#410) > Add tests for Go 1.9 (#421) > changed registered paths for WKT to use proto import path google/protobuf/... (#412) > jsonpb: unmarshal JSON null to nil map/slice instead of empty instance (#404) > jsonpb: unmarshal JSON "null" for WKT (#394) > Remove unnecessary conversions (#315) > Fix Travis config and add status (#381) > Add travis-ci configuration. (#379) > Fix protoc-gen-go tests (#371) > ptypes: sync internal development (#374) > Deserialize JSON NaN, Infinity and -Infinity to corresponding Go values (#363) > Fix JSON marshaling of Any containing object that implements JSONPBMarshaler (#361) > Fix jsonpb to serialize NaN and Infinity as special strings (#242) > Fix doc re. getters for proto3, i.e. getters are now generated on all fields (#354) > Fixed broken tests on pre-go1.8 #356 (#359) > Fix jsonpb to emit zero values for Map, Slice, Ptr when EmitDefaults=true > Support custom JSON (de)serialization in jsonpb > protoc-gen-go: update Makefiles for protobuf 3.3.0 (#348) > regenerate pb.go files with protobuf 3.3.0 > protoc-gen-go: follow the new code generation comment convention (#329) > Simplify the installation step (#345) > jsonpb: unmarshalling of Struct, ListValue, Value, Any and proto2 extensions; and marshalling of ListValue. > Merge pull request #326 from golang/revert-275-go-context-stdlib > Update to standard library context package. (#275) > protobuf: Regenerate golden files. > Makefile: Make "make test" work on OS X. > Merge pull request #290 from natefinch/fix-import > descriptor: rename generated protobuf package on import. > jsonpb: merge golang/protobuf#255 > proto: Add a descriptor subpackage. > proto: Fix a Marshal race on messages with extensions. > jsonpb: treat `null` JSON values for `Timestamp` and `Duration` as defaults (#255) > Generate pb.go files after golang/protobuf@cb9b777 > Add a benchmark demonstrating lock contention when Marshaling/Unmarshaling maps. > Regenerate pb.go files after golang/protobuf@24f28ae > protoc-gen-go: Add Filename to ExtensionDesc. > Run 'make generate-test-pbs' in proto/ to regenerate proto3.pb.go testdata > Generate new pb.go files. > proto: generate Get methods for fields of basic type in proto3 > Merge pull request #249 from Huawei-PTLab/master > improve error message for duplicate oneof in text parsing PiperOrigin-RevId: 138128520 > grpc: update generated code version > Produce an error when unmarshaling text protos if a oneof field is set more than once. PiperOrigin-RevId: 137859856 > Fix tests. > Add a decoding benchmark for multiple small repeated ints PiperOrigin-RevId: 135693188 > Fix jsonpb for Go 1.8 > Unroll DecodeVarint to speed up int32/int64/uint64 slice decoding. > Note that Buffer.Unmarshal does NOT reset the destination protobuf. > Add Varint decoding benchmarks PiperOrigin-RevId: 135181742 > Add protobuf benchmarks for varint encoding. > proto: In Size, don't double-count the tagcode for structs that implement Marshaler. > Merge pull request #235 from lstoll/lstoll-mod-nanos-correctly > Allow t/f and True/False while parsing text protos > Change MessageName to check if Message has an XXX_MessageName() method, and use the name returned by that method instead of internal registry when present. PiperOrigin-RevId: 131111087 > proto.Equal: document map equality and clarify the rule for repeated fields. PiperOrigin-RevId: 130971987 > Remove conformance binary from repository > _conformance: generate proto > third_party/golang/protobuf: open source conformance test runner PiperOrigin-RevId: 130532724 > Fix comment for Buffer.index field > Update Go tests for C++ JSON name change Submodule src/github.com/jeffpak/local-node-plugin 1406f1a0e..3e0ef63d1: > Update to CSI v0.3.0 Signed-off-by: Dave Walter <[email protected]>
|
Hey davewalter! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/159840914 The labels on this github issue will be updated when the story is started. |
|
Thanks, @davewalter! Prioritizing for the Diego team to evaluate and merge. |
danail-branekov
pushed a commit
to masters-of-cats/diego-release
that referenced
this pull request
Sep 12, 2018
Submodule src/code.cloudfoundry.org/executor 23ff7f3..08a81a5: > use the new gomega Receive matcher to cleanup the tests Submodule src/github.com/onsi/ginkgo 67b9df7f5..c73579c58: > Increase eventually timeout to 30s > Clarify asynchronous test behaviour > Travis badge should only show master > v1.5.0 > Bring the changelog up to date (cloudfoundry#470) > Merge pull request cloudfoundry#466 from onsi/issue-464 > Merge pull request cloudfoundry#468 from onsi/update-changelog > Merge pull request cloudfoundry#459 from onsi/unfocus-exclude-vendor > Merge pull request cloudfoundry#456 from idoru/ignore-suite-with-ignored-go-files > Merge pull request cloudfoundry#455 from onsi/flaky-measurements > Merge pull request cloudfoundry#423 from alamages/coverage-tests-fix > Add go 1.10 to travis > Merge pull request cloudfoundry#448 from melnikk/master > Merge pull request cloudfoundry#451 from onsi/go-1.10-coverage-test > Merge pull request cloudfoundry#446 from onsi/do-not-create-outputdir > Add an extra new line after reporting spec run completion > Merge pull request cloudfoundry#441 from blgm/releasing > Merge pull request cloudfoundry#443 from onsi/add-go-1.10 > Merge pull request cloudfoundry#438 from onsi/issue-436 > Merge pull request cloudfoundry#434 from mezis/blur-specify > Merge pull request cloudfoundry#430 from onsi/issue-426 > Add tests for When/Specify > Update comments and README.md for `When` DSL > Merge pull request cloudfoundry#386 from akshaymankar/when > Merge pull request cloudfoundry#383 from eloycoto/master > fix the tests on go versions <1.9 > add a test case for cloudfoundry#415 > Fix Ginkgo stack trace on failure for Specify > Merge pull request cloudfoundry#409 from lflux/readme-update > Merge pull request cloudfoundry#400 from alex-slynko/patch-1 > Merge pull request cloudfoundry#403 from alex-slynko/fix_govet > Merge pull request cloudfoundry#404 from lflux/travis-go-1.9 > Merge pull request cloudfoundry#399 from alex-slynko/fix_imports > Merge pull request cloudfoundry#401 from alex-slynko/patch-2 > Merge pull request cloudfoundry#398 from martinxsliu/generated-import-ordering > Merge pull request cloudfoundry#390 from DennisDenuto/master > Re-add noisySkippings flag > Replace GOPATH in Environment > Allow coverage to be displayed for focused specs (cloudfoundry#367) > ensure customer reporters are run before default reporter > Handle -outputdir flag (cloudfoundry#364) > Handle -coverprofile flag (cloudfoundry#355) > v1.4.0 > v1.4.0 > fix CONTRIBUTING.md > Add a CONTRIBUTING.md file > add -timeout flag. fixes cloudfoundry#248 > add 'requireSuite' flag to cause failure if there are test files but no suite (cloudfoundry#359) > update changelog > emit compilation output > link to vscode extension > add ginkgo watch -watchRegExp fixes cloudfoundry#356 > remove fixCompilationOutput (fixes cloudfoundry#357) > Remove mailing list > Add Rick and Morty quote to untilItFails messages (cloudfoundry#354) > Revert "Fix wrong repo URL (cloudfoundry#351)" (cloudfoundry#352) > Fix wrong repo URL (cloudfoundry#351) > Lack of test suites no longer breaks builds (cloudfoundry#347) > Update CHANGELOG.md > Warn when a suite has test files but no tests to run (cloudfoundry#345) > fix flaky test by, you know, not relying on obscure go internals > update .travis.yml to get latest patch releases > fix failing go 1.5 tests > ensure tests pass on Go 1.8.1 > v1.3.1: Actually change the CLI version > print location of test suite that failed to report back (cloudfoundry#339) > v1.3.0 Submodule src/github.com/onsi/gomega 777f4d387..41673fd8f: > allow 'Receive' matcher to be used with concrete types (cloudfoundry#286) > Fix data race in ghttp server (cloudfoundry#283) > Travis badge should only show master > v1.4.0 > Update the CHANGELOG.md with all changes since last release > Improve message from AssignableToTypeOf when expected value is nil (cloudfoundry#281) > Merge pull request cloudfoundry#278 from benmoss/master > Merge pull request cloudfoundry#273 from vayan/master > change Ω to Expect in most places (cloudfoundry#268) > Merge pull request cloudfoundry#272 from trayo/master > Merge pull request cloudfoundry#271 from onsi/add-go-1.10 > Merge pull request cloudfoundry#270 from Patagonicus/master > Remove tests that tried to verify signals as async > Merge pull request cloudfoundry#262 from onsi/issue-173 > Merge pull request cloudfoundry#259 from onsi/issue-258 > v1.3.0 > Add more robust support for XUnit style tests > Merge pull request cloudfoundry#256 from onsi/allow-multiple-go-routines > Merge pull request cloudfoundry#253 from challiwill/master > Merge pull request cloudfoundry#249 from alex-slynko/fix_govet > Merge pull request cloudfoundry#247 from alex-slynko/fix_imports > Merge pull request cloudfoundry#243 from williammartin/find-first-mismatch-oob > Merge pull request cloudfoundry#241 from ivy/fix-typos > Merge pull request cloudfoundry#218 from alex-slynko/patch-1 > Merge pull request cloudfoundry#239 from williammartin/parallel-testing > Merge pull request cloudfoundry#235 from onsi/fix-227 > MatchXML should ignore the order of xml node attributes > Merge pull request cloudfoundry#233 from kaedys/bugfix/error-matcher-fix > Uses equality matcher for matching error strings Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Diego Team!
This PR bumps a few submodules to support CSI spec v0.3.0. It's worth pointing out that one of those is protobuf. We have run all the unit tests and inigo successfully, so we think that everything should be good to go.
Let us know if you have any questions.
@paulcwarren and Dave