Add CC-Uploader certs for mutual TLS with CC #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following properties will be required for CC-Uploader as of the next CAPI release: - capi.cc_uploader.cc.ca_cert - capi.cc_uploader.cc.client_cert - capi.cc_uploader.cc.client_key Signed-off-by: Lyle Franklin <[email protected]> [#139996781]
|
Hey ljfranklin! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/141442163 The labels on this github issue will be updated when the story is started. |
Author
|
Let us know if we missed updating some other manifest generation file. |
Contributor
|
Thanks, @ljfranklin! Makes sense, prioritizing for the Diego team to review. Best, |
cf-gitbot
added
scheduled
in progress
and removed
unscheduled
scheduled
in progress
labels
cf-gitbot
added
in progress
delivered
accepted
and removed
in progress
delivered
labels
jvshahid
added a commit
that referenced
this pull request
Jun 5, 2018
Submodule src/code.cloudfoundry.org/executor 23ff7f3..08a81a5: > use the new gomega Receive matcher to cleanup the tests Submodule src/github.com/onsi/ginkgo 67b9df7f5..c73579c58: > Increase eventually timeout to 30s > Clarify asynchronous test behaviour > Travis badge should only show master > v1.5.0 > Bring the changelog up to date (#470) > Merge pull request #466 from onsi/issue-464 > Merge pull request #468 from onsi/update-changelog > Merge pull request #459 from onsi/unfocus-exclude-vendor > Merge pull request #456 from idoru/ignore-suite-with-ignored-go-files > Merge pull request #455 from onsi/flaky-measurements > Merge pull request #423 from alamages/coverage-tests-fix > Add go 1.10 to travis > Merge pull request #448 from melnikk/master > Merge pull request #451 from onsi/go-1.10-coverage-test > Merge pull request #446 from onsi/do-not-create-outputdir > Add an extra new line after reporting spec run completion > Merge pull request #441 from blgm/releasing > Merge pull request #443 from onsi/add-go-1.10 > Merge pull request #438 from onsi/issue-436 > Merge pull request #434 from mezis/blur-specify > Merge pull request #430 from onsi/issue-426 > Add tests for When/Specify > Update comments and README.md for `When` DSL > Merge pull request #386 from akshaymankar/when > Merge pull request #383 from eloycoto/master > fix the tests on go versions <1.9 > add a test case for #415 > Fix Ginkgo stack trace on failure for Specify > Merge pull request #409 from lflux/readme-update > Merge pull request #400 from alex-slynko/patch-1 > Merge pull request #403 from alex-slynko/fix_govet > Merge pull request #404 from lflux/travis-go-1.9 > Merge pull request #399 from alex-slynko/fix_imports > Merge pull request #401 from alex-slynko/patch-2 > Merge pull request #398 from martinxsliu/generated-import-ordering > Merge pull request #390 from DennisDenuto/master > Re-add noisySkippings flag > Replace GOPATH in Environment > Allow coverage to be displayed for focused specs (#367) > ensure customer reporters are run before default reporter > Handle -outputdir flag (#364) > Handle -coverprofile flag (#355) > v1.4.0 > v1.4.0 > fix CONTRIBUTING.md > Add a CONTRIBUTING.md file > add -timeout flag. fixes #248 > add 'requireSuite' flag to cause failure if there are test files but no suite (#359) > update changelog > emit compilation output > link to vscode extension > add ginkgo watch -watchRegExp fixes #356 > remove fixCompilationOutput (fixes #357) > Remove mailing list > Add Rick and Morty quote to untilItFails messages (#354) > Revert "Fix wrong repo URL (#351)" (#352) > Fix wrong repo URL (#351) > Lack of test suites no longer breaks builds (#347) > Update CHANGELOG.md > Warn when a suite has test files but no tests to run (#345) > fix flaky test by, you know, not relying on obscure go internals > update .travis.yml to get latest patch releases > fix failing go 1.5 tests > ensure tests pass on Go 1.8.1 > v1.3.1: Actually change the CLI version > print location of test suite that failed to report back (#339) > v1.3.0 Submodule src/github.com/onsi/gomega 777f4d387..41673fd8f: > allow 'Receive' matcher to be used with concrete types (#286) > Fix data race in ghttp server (#283) > Travis badge should only show master > v1.4.0 > Update the CHANGELOG.md with all changes since last release > Improve message from AssignableToTypeOf when expected value is nil (#281) > Merge pull request #278 from benmoss/master > Merge pull request #273 from vayan/master > change Ω to Expect in most places (#268) > Merge pull request #272 from trayo/master > Merge pull request #271 from onsi/add-go-1.10 > Merge pull request #270 from Patagonicus/master > Remove tests that tried to verify signals as async > Merge pull request #262 from onsi/issue-173 > Merge pull request #259 from onsi/issue-258 > v1.3.0 > Add more robust support for XUnit style tests > Merge pull request #256 from onsi/allow-multiple-go-routines > Merge pull request #253 from challiwill/master > Merge pull request #249 from alex-slynko/fix_govet > Merge pull request #247 from alex-slynko/fix_imports > Merge pull request #243 from williammartin/find-first-mismatch-oob > Merge pull request #241 from ivy/fix-typos > Merge pull request #218 from alex-slynko/patch-1 > Merge pull request #239 from williammartin/parallel-testing > Merge pull request #235 from onsi/fix-227 > MatchXML should ignore the order of xml node attributes > Merge pull request #233 from kaedys/bugfix/error-matcher-fix > Uses equality matcher for matching error strings Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following properties will be required for CC-Uploader as of the next
CAPI release:
Signed-off-by: Lyle Franklin [email protected]
[#139996781]