Generalize running_in_container function #242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows jobs to run correctly in garden-runc containers as well as in the previously supported garden-linux and docker containers.
|
Hey ematpl! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
1 similar comment
|
Hey ematpl! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/136407357 The labels on this github issue will be updated when the story is started. |
|
Merged by diego-release/8b01bbd |
emalm
added a commit
to emalm/capi-release
that referenced
this pull request
Jan 12, 2017
This change allows jobs to run correctly in garden-runc containers as well as in the previously supported garden-linux and docker containers. See also cloudfoundry-attic/cf-release#1130, cloudfoundry/diego-release#242, cloudfoundry/routing-release#56 + related discussion on https://www.pivotaltracker.com/story/show/135771525.
3 tasks
emalm
added a commit
to emalm/capi-release
that referenced
this pull request
Jan 12, 2017
This change allows jobs to run correctly in garden-runc containers as well as in the previously supported garden-linux and docker containers. See also cloudfoundry-attic/cf-release#1130, cloudfoundry/diego-release#242, cloudfoundry/routing-release#56 + related discussion on https://www.pivotaltracker.com/story/show/135771525.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows jobs to run correctly in garden-runc containers
as well as in the previously supported garden-linux and docker containers.