allow configuration of nats-tls hostname #453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer a locally specified hostname in the route-emitter and route-emitter windows spec over the use of the nats-tls link instances.address. This is required if specifying a bosh-dns-alias for nats-tls. It is helpful to have a bosh-dns-alias when connecting to a host using TLS for hostname verification. [#170956876](https://www.pivotaltracker.com/story/show/170956876) Co-authored-by: Aidan Obley <[email protected]> Co-authored-by: Clay Kauzlaric <[email protected]>
|
|
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/171134113 The labels on this github issue will be updated when the story is started. |
|
Diego v2.44.0 |
cf-gitbot
added
in progress
delivered
accepted
and removed
delivered
in progress
labels
tas-runtime-bot
added a commit
that referenced
this pull request
Oct 4, 2024
…dot credhub-cli diego-ssh dockerapplifecycle ecrhelper executor fileserver healthcheck inigo localdriver locket operationq rep route-emitter vizzini volman workpool garden grootfs guardian idmapper Submodule src/code.cloudfoundry.org/auction aac85ac..63a0ea2: > Sync README.md > pull info from readme into individual docs > Catch or explicitly ignore unhandled errors (#19) Submodule src/code.cloudfoundry.org/auctioneer 127aac4..ad722c3: > Sync README.md > Catch or explicitly ignore unhandled errors (#19) Submodule src/code.cloudfoundry.org/bbs 4b574f9..d12ace5: > Sync README.md > fix more broken links > fix broken links > add quotes around title > add ordering to doc names > add metadata to the top of the docs > move docs to 'docs' dir instead of 'doc' > fix-broken-links (#105) > Catch or explicitly ignore unhandled errors (#104) Submodule src/code.cloudfoundry.org/buildpackapplifecycle 888a70480..9c4775059: > Sync README.md > Merge pull request #73 from cloudfoundry/fix-g104 Submodule src/code.cloudfoundry.org/cacheddownloader a52cc2a85..fdbfab074: > Sync README.md > Catch or explicitly ignore unhandled errors (#39) Submodule src/code.cloudfoundry.org/cfdot 864c4a6..f66d17a: > Sync README.md > fix broken link > move info from readme into individual docs Submodule src/code.cloudfoundry.org/credhub-cli 17db04838..18c8d3fad: > Bump go modules Submodule src/code.cloudfoundry.org/diego-ssh 0e1b7b1..3efd7e8: > Sync README.md > move info from readme into individual ordered docs > Catch or explicitly ignore unhandled errors Submodule src/code.cloudfoundry.org/dockerapplifecycle e83857a..80b4aa4: > Sync README.md > Catch or explicitly ignore unhandled errors (#22) Submodule src/code.cloudfoundry.org/ecrhelper 463ffec..db91b0d: > Sync README.md Submodule src/code.cloudfoundry.org/executor a3ae097..5c6320b: > Fix executor error handling bug (#108) > Add unit test for cachedDownloader.New > Handle error returned from cacheddownloader.New > Sync README.md > Catch or explicitly ignore unhandled errors (#105) Submodule src/code.cloudfoundry.org/fileserver 3798a9e..bbfd349: > Sync README.md > Catch or explicitly ignore unhandled errors (#11) Submodule src/code.cloudfoundry.org/healthcheck f9213fb..67668d5: > Sync README.md > move info from readme into individual ordered docs > Catch or explicitly ignore unhandled errors (#14) Submodule src/code.cloudfoundry.org/inigo 3d1daff..0b7dbcf: > Catch or explicitly ignore unhandled errors (#35) Submodule src/code.cloudfoundry.org/localdriver cc1bb5a..5780700: > Remove commented out code (#7) > Sync README.md > move info from readme into individual ordered docs > Catch or explicitly ignore unhandled errors (#6) Submodule src/code.cloudfoundry.org/locket 9ed239545..5e3ea80de: > Sync README.md > fix broken links > add doc about locket client from readme > order docs > add metadata to docs > move docs from dir 'doc' to the standardized 'docs' > fix broken link in doc Submodule src/code.cloudfoundry.org/operationq a959afa..bf08b68: > Sync README.md Submodule src/code.cloudfoundry.org/rep 979b574..a916b34: > Sync README.md > point to diego-release contributor guide for running tests Submodule src/code.cloudfoundry.org/route-emitter 1ed8242..dc53cac: > Sync README.md > Catch or explicitly ignore unhandled errors (#46) Submodule src/code.cloudfoundry.org/vizzini 56193ba..729dacb: > fix-broken-links (#11) Submodule src/code.cloudfoundry.org/volman d3e7f15..64579f3: > Sync README.md > Catch or explicitly ignore unhandled errors (#10) Submodule src/code.cloudfoundry.org/workpool b6c2fa5..8c0f2d1: > Sync README.md > move info from readme into individual ordered docs Submodule src/garden 5948a5d99..4740aa5b7: > Update go.mod dependencies > Update go.mod dependencies Submodule src/grootfs fd0597ed7..826163f4e: > Update go.mod dependencies > fix links in readme > fix link to ginkgo repo > fix broken docker docs links > Update go.mod dependencies > Merge pull request #269 from cloudfoundry/g301-followup Submodule src/guardian cd421f913..78950d270: > Merge pull request #453 from cloudfoundry/fix-g104 Submodule src/idmapper 92d3aae90..12677c251: > Update go.mod dependencies > fix link in readme > Update go.mod dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer a locally specified hostname in the route-emitter and route-emitter
windows spec over the use of the nats-tls link instances.address.
This is required if specifying a bosh-dns-alias for nats-tls. It is
helpful to have a bosh-dns-alias when connecting to a host using TLS for
hostname verification.
#170956876
Co-authored-by: Aidan Obley [email protected]
Co-authored-by: Clay Kauzlaric [email protected]
Thank you for submitting a pull request to the diego-release repository. We appreciate the contribution. To help us with getting better context for the pull request please follow these guidelines:
Please make sure to complete the following steps
developbranch.Please provide the following information when submitting pull request:
What is this change about?
What problem it is trying to solve?
What is the impact if the change is not made?
How should this change be described in diego-release release notes?
Please provide any contextual information.
Tag your pair, your PM, and/or team!
Thank you!