Skip to content

Fix version override in windows cell manifest gen #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2016
Merged

Fix version override in windows cell manifest gen #214

merged 1 commit into from
Oct 26, 2016

Conversation

@emalm
Copy link
Contributor

@emalm emalm commented Oct 25, 2016

  • add a ':' so that the argument value is captured

@emalm
Fix version override in windows cell manifest gen
d340da8 
* add a ':' so that the argument value is captured
@cfdreddbot
Copy link

cfdreddbot commented Oct 25, 2016

Hey ematpl!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

1 similar comment
@cfdreddbot
Copy link

cfdreddbot commented Oct 25, 2016

Hey ematpl!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

cf-gitbot commented Oct 25, 2016

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/133142187

The labels on this github issue will be updated when the story is started.

@jfmyers9 jfmyers9 merged commit 67b4748 into develop Oct 26, 2016
@emalm emalm deleted the fix-windows-cell-version-overrides branch October 26, 2016 00:43
nimakaviani added a commit that referenced this pull request Jan 5, 2017
@nimakaviani
bump bbs protobuf
8dcb70e 
[finishes #136922331]

Submodule src/code.cloudfoundry.org/bbs b33de3b..ac5af56:
  > remove unused methods
  > Use ProtoRoutes for the routes field instead of plain bytes
  > listen on debug address from bbs json config
Submodule src/github.com/gogo/protobuf e33835a64..f9114dace:
  > Allow usage of message types with customtype override (#239)
  > Don't generate unused extensionToGoString method (#245)
  > always check packed for scalar repeated fields when unmarshaling
  > support proto3 packed=false
  > [BUGFIX] Fix conformance run (#241)
  > merged cf10ca0ea91371dd30946defd93a0ed43aa1efe7 from golang/protobuf
  > merged and modified to remove dependencies 62e782f47e4c57935994133e44f1716d281504e4 from golang/protobuf
  > merged 224aaba33b1ac32a92a165f27489409fb8133d08 from golang/protobuf
  > merged cb9b7771abc2a63ab206dde76539f08f66ab994d from golang/protobuf
  > merged 24f28ae800abfde9310e779f94be606b1a98a3fc from golang/protobuf
  > merged da116c3771bf4a398a43f44e069195ef1c9688ef from golang/protobuf
  > merged d6803ead56f623f1085f33f981907442aca44809 from golang/protobuf
  > buildable by gopherjs (#237)
  > less go versions are tested because travis breaks for go 1.5.4 and go… (#233)
  > add compare method to most well known types
  > merged a66a4fa9a8dd2304462f7aad7161e8bf53eee461 09b5638faf9cc5d6d0230ab90fd7e2b5a15d19ea 2bc9827a78f95c6665b5fe0abd1fd66b496ae2d8 from golang/protobuf
  > commented out another benchmark because it is using features from go1.7
  > commented out some benchmarks with are using features from go1.7
  > merged from golang/protobuf: 99d46c5d2d9449e5ee7feaf73228ba989a9cd649 5fb654a4b202da10dadb417e7132400efafe4c87 1976b9edadc994262a35b3e30a378efeb07e44ac 5d356b9d1c22e345c2ea08432302e82fd02d8a61 730e9124bf047f25aebb052d2a74c609414c12e5 3571fb58c2425ca244702e8e2dfb156d95c44246 98fa357170587e470c5f27d3c3ea0947b71eb455
  > updated to protoc 3.1.0 and fixed casttype string populate
  > Replace "data" with "dAtA" in marshalling. (#215)
  > Fixes panic message in enumstringer plugin which refers to a setting which doesn't exist. (#214)
  > fix for issue 207
  > fix for issue 209: dont import types when its not used
  > merged df1d3ca07d2d07bba352d5b73c4313b4e2a6203e from golang/protobuf
  > merged e8b7c67215abd7972a3b83f7620e04e7fa5e18e9 from golang/protobuf
  > merged 1f49d83d9aa00e6ce4fc8258c71cc7786aec968a from golang/protobuf
  > merged 5bdfda0a01d81b6b1694960c0d8d84c49c10d0ab from golang/protobuf
  > merged ef00c02a19ffe87bd3f6866760e531b54ada72c6 from golang/protobuf
  > conformance min-version 3
  > added field_mask and merged conformance from golang/protobuf: 855c5d638b1772fa56ac51335d18ad4d633a2daf, f592bd283e9ef86337a432eb50e592278c3d534d
  > govet fix for go1.6 and go1.5
  > merged 7390af9dcd3c33042ebaf2474a1724a83cf1a7e6 from golang/protobuf
  > merged 2c1988e8c18d14b142c0b472624f71647cf39adb from golang/protobuf
  > merged c3cefd437628a0b7d31b34fe44b3a7a540e98527 from golang/protobuf
  > merged 1687f003bf0280bd6182a5a1c7241856b269a6c0 from golang/protobuf
  > packed repeated fields and merged 2c2f7268d78c9b309e301a6df31de3b6e4430dca from golang/protobuf
  > merged 51fb628d55f334811b0d925d6a2be809c75de49b from golang/protobuf
  > updated proto3 version to 3.0.2 in readme
  > stopped testing go1.4.2 because of timestamp and duration errors json errors.  The likelihood of someone using proto3s newest features but still using go1.4.2 seems quite unlikely
  > some proto text cleanup for time.Time and time.Duration
  > Merge branch 'master' into std
  > docs for stdtime and stdduration
  > govet fixes
  > proto text for time.Time and time.Duration
  > json fullcircle fix
  > renabled full circle tests
  > encoders and decoders for repeated time.Time
  > decoders and encoders for repeated time.Duration
  > encoders and decoders for time.Duration non nullable
  > encoder and decoder for time.Time non nullable
  > nullable time.Time decode and encode
  > map is fixed for time and duration
  > nullable duration encoder and decoder working
  > merge
  > small comments removed
  > ready for encs and decs for time.Time and time.Duration
  > merge
  > Merge branch 'master' into std
  > added more tests for jsonpb and fixes for time.Duration
  > fixed jsonpb for time
  > more tests for std and fix for equal for nullable repeated durations
  > unmarshal fix for std time and duration
  > fixed size for maps with std time and duration
  > populate fixed for maps
  > marshalto code generation for std time and duration
  > std time is generated for maps
  > generator fixed for maps and oneof of std time and duration
  > all the tests
  > Merge branch 'master' into std
  > marshal std functions
  > plugin size for time.Time and time.Duration
  > populate plugin working for std time and duration
  > merge
  > std time and duration
  > more tests for well known types
  > govet fix for older versions of go
  > merged c27503d0b47c72ba38d300aeaf9b82071a7f5d86 from golang/protobuf
  > merged bf531ff1a004f24ee53329dfd5ce0b41bfdc17df from golang/protobuf
  > merged d120e2f9573fd13ef964982b1d1f118cee00e4d0 from golang/protobuf
  > merged 1cc4d6fa4abfabc2fe9cb202f3f1dde0e1032e86 from golang/protobuf
  > merged 552c7b9542c194800fd493123b3798ef0a832032 from golang/protobuf
  > merged 45760678a2e5102a51433d40069dbc9ec5b26753 from golang/protobuf
  > merged c6184d34b2de4dfe1105ca59c95bda6abdcaf367 from golang/protobuf
  > merged 3e847b4d77a69fe9c6eb2df6d7957c5a73ba192d from golang/protobuf
  > merged 553c764c95697e59b8bcc8b82a860cdf42447de9 from golang/protobuf
  > merge 3c84672111d91bb5ac31719e112f9f7126a0e26e from golang/protobuf
  > merge private validateDuration, but not DurationFromProto -> Duration function rename and not the move from types to ptypes from 127091107ff5f822298f1faa7487ffcf578adcf6 golang/protobuf
  > merged 89238a3245885ada85d2f4fdbe76adae392df69b from golang/protobuf
  > merge 8ea33d25124a63a964f248594fdd8887178543f2 from golang/protobuf
  > added empty.proto
  > fix protoc-gen-combo to be able to take M parameters in gogo_out and generated combos for test/types
  > added a fist use of timestamp in a test and regenerated types with more methods and functions
  > added a comment about why reserved is removed from the descriptor.proto
  > trying a different strategy with the reserved keyword in the descriptor
  > fixed gogo.proto for protoc version 3
  > fixed min version for plugin.proto
  > fixed descriptor gen for proto3
  > protoc-min-version 3.0.0 for types
  > generated proto types
  > Merge branch 'master' into wkt
  > added wkt proto files
  > Updateded Readme: formatting
  > Updated Readme: mentions, users and install instructions
  > fix for issue gogo/protobuf#194
  > removed drone build status from extensions
  > fixed extensions link
  > moving docs into the repo
  > protoc-gen-gostring
  > go vetted extension range
  > regenerate with proto3.0.0
  > go 1.4.2 for testing
  > updated readme with new testing versions of go and protoc
  > updated travis to proto3 and go1.7
  > Go1.7 vet fixes (#192)

Signed-off-by: Brandon Shroyer <[email protected]>
sunjayBhatia added a commit that referenced this pull request Nov 21, 2019
@sunjayBhatia
bump bbs executor locket opencensus-proto go-control-plane protoc-gen…
1e997f4 
…-validate googleapis protobuf protoc-gen-validate

[finishes #169766863](https://www.pivotaltracker.com/story/show/169766863)

Submodule src/code.cloudfoundry.org/bbs c8e9aac..0cb4cac:
  > Regenerate models with latest protobuf
Submodule src/code.cloudfoundry.org/executor 71aaf90..739290b:
  > Updates for latest envoy go-control-plane
Submodule src/code.cloudfoundry.org/locket fc205fac2..b8526ba7b:
  > Regenerate models with latest protobuf
Submodule src/github.com/census-instrumentation/opencensus-proto 000000000...d89fa54de (new submodule)
Submodule src/github.com/envoyproxy/go-control-plane 8a91fb26f..34c8be46e:
  > Mirrored from envoyproxy/envoy @ 274f17cabe7f49f105c82919937ab710b9428261
  > Mirrored from envoyproxy/envoy @ 5536ce73026fcbf1c176c09d409a981d67981047
  > Mirrored from envoyproxy/envoy @ df6d3bc453167a8e9fd29662280859b4f56f0af8
  > Mirrored from envoyproxy/envoy @ 8e368e4bdfa8f220c5f4cb03ca61587ae1a3d118
  > Mirrored from envoyproxy/envoy @ 466c00b47c199601f81d45e7001fdd3840439d6e
  > Fix generic comparisons on protobuf messages (#241)
  > Mirrored from envoyproxy/envoy @ 443bc3345b0e3db99a3df03d52f317697b99d5d7
  > Adding support to shutdown handler (#239)
  > Mirrored from envoyproxy/envoy @ 20ca0ae3bdd9c2a69194203f5e1d2eca92ce2b48
  > Mirrored from envoyproxy/envoy @ cf74f816933d1350d7c588a3b8478dd399ce3d18
  > Mirrored from envoyproxy/envoy @ 0aed05aecd17576b0dd96f3e4126acd1c24a02bc
  > Mirrored from envoyproxy/envoy @ d9fc7f7a2d5c2098e191adb2502c8e04917abdd1
  > Mirrored from envoyproxy/envoy @ d36adbb5c4aad13af21f109b86978b8478f54409
  > Mirrored from envoyproxy/envoy @ 174ba21bb88b7d50d0b7efeefd0c43268b2afd5e
  > Mirrored from envoyproxy/envoy @ 57748e72f79e14217980b09d20c17f865459231f
  > Mirrored from envoyproxy/envoy @ ee17a88621b374715590f4cf62b15b4258a3d21f
  > Mirrored from envoyproxy/envoy @ 2d7e2bbc1496b0d9d1d1462fe5ddee2f1eaf374f
  > Mirrored from envoyproxy/envoy @ 86420eb64a750fd6025cf5efc8b846c8fe63f0c9
  > Mirrored from envoyproxy/envoy @ a55621cb23f69aac44a6a1fc5ba1ffd1475293e5
  > Mirrored from envoyproxy/envoy @ b4ca6034aae03083e65b058beaebc7404d5cf456
  > Mirrored from envoyproxy/envoy @ 63455de2ee5ee9b916ae73a805f8177996ded618
  > Mirrored from envoyproxy/envoy @ 7846427d7aafb9e023c38bb6e704262f7c724c92
  > Mirrored from envoyproxy/envoy @ e2cf41606c42cd18b5ac5fd2add9cf983ece9172
  > Mirrored from envoyproxy/envoy @ 6b3df463f5289e13076b9a55d37e289661ed6f42
  > Mirrored from envoyproxy/envoy @ c63c1e83989a10512546d67df44629029d1be23c
  > Mirrored from envoyproxy/envoy @ fbd056aae8d74e8acae8880c0766af588a6c3583
  > Mirrored from envoyproxy/envoy @ 68ca6746d168c6cea26d21479ef50b2be9aaa25d
  > Mirrored from envoyproxy/envoy @ f68368f1a497d8f9254a714c2694cee88477438d
  > Mirrored from envoyproxy/envoy @ b331807fcfccee404863284b55d12da6e1775df0
  > Mirrored from envoyproxy/envoy @ 8e0b240b0e0abcda07b7b259178bdad60a699019
  > Mirrored from envoyproxy/envoy @ e3247539bcc39f3111287b479a85e51655a6f1db (#232)
  > Mirrored from envoyproxy/envoy @ 72fc3606045c519264c4358808ebb88fb82d947c (#231)
  > Implement RTDS (#229)
  > Transition to use golang/protobuf to support automated code generation (#226)
  > fixing readme import and type in example (#224)
  > add http_inspector to wellknown.go (#219)
  > fix accesslog example (#216)
  > update go-control-plane (#214)
  > Changes the HTTP status code to 304 (as opposed to 500) when a fetch is skipped due to the client's version already being up-to-date. (#209)
  > add run_docker.sh and update README (#211)
  > update to the latest (#208)
  > add RBAC to wellknown.go (#207)
  > update data-plane-api to 5ced57515167940657b58ba771de97d753119aea (#204)
  > Replace gogo/googleapis with istio.io/gogo-genproto (#202)
  > Update generated files (#201)
  > add OWNERS.md (#200)
  > Update and fix script (#199)
  > update data-plane-api (#192)
  > unpin envoy (#189)
  > update data-plane-api (#188)
  > Update protobuf generation script (#181)
  > introduce go modules (#179)
  > update data-plane-api to da8a43117df30a8439d6290a34e9e82e19006d1e (#178)
  > Update data-plane-api to 758fe69d11f5dba13f8297e4cd615ef4be0cbc4c (#177)
  > update dependencies (#169)
  > Add a GetSnapshot method to SnapshotCache interface (#163)
  > Vhds protobufs (#167)
  > update data-plane-api to 698cf2f460236d2e6f6787394025c0145ca07713 (#166)
  > Update data plane to 3cb3571f093602b7d6a06945906802666febcf66 (#162)
  > update data-plane-api to 4f4ee118c54b7a52393c7d45b94f6bd5040a7118 (#158)
  > Update data-plane-api to 2fcac33dc159d3f6bab7cf84865177f75d32ba05 (#157)
  > test: use typed configs (#156)
  > Feature: Add support for stale-bot (#145)
  > Allow Callbacks.OnStreamRequest() to return an error to close stream (#155)
  > Update data-plane-api to 0afc79c323bcc0044381e8edb1dbdb87d35d6948 (#154)
  > Create a WKT for the MySQL Proxy (#152)
  > add SDS support (#56)
  > Update data-plane-api and istio.io/gogo-genproto (#150)
  > README: fix indentation of Go code block (#147)
  > Testing: Move creation of linux-test bin to docker (#143)
  > Upgrade: Update golang from 1.10 to 1.11 (#144)
Submodule src/github.com/envoyproxy/protoc-gen-validate 000000000...9eff07ddf (new submodule)
Submodule src/github.com/golang/protobuf b4deda097..6c65a5562:
  > jsonpb: fix marshaling of Duration
  > Log parsing errors using log pkg (#851)
  > fix indentation in jsonpb with Any messages
  > protoc-gen-go/grpc: use status and code packages only if needed (#820)
  > protoc-gen-go/grpc: inline errUnimplemented function (#818)
  > Add UnimplementedServer for server interface (#785)
  > Delete the conformance test (#808)
  > proto: remove test dependency on experimental packages (#805)
  > ptypes: More cleanly construct a Timestamp (#797)
  > ptypes: Avoid assuming time.Duration is nanoseconds (#796)
  > protoc-gen-go: fix oneof name mangling regression (#782)
  > README.md: document how to build a specific version of protoc-gen-go (#764)
  > protoc-gen-go: generate XXX_OneofWrappers instead of XXX_OneofFuncs (#760)
  > all: update to v3.6.1 (#757)
  > proto: store extension values according to protobuf data model (#746)
  > proto: deprecate {Unm,M}arshalMessageSet{JSON} (#741)
  > all: increase minimum supported version to go1.9 (#742)
  > protoc-gen-go: reference publicly imported symbols directly
  > protoc-gen-go: add test for use of publicly imported symbol
  > protoc-gen-go: include groups in public import forwarders
  > protoc-gen-go: expand import_public test files
  > protoc-gen-go: normalize floating-point default values (#737)
  > protoc-gen-go: generate deprecation comments for oneof fields
  > protoc-gen-go: add test case for deprecated oneof field
  > protoc-gen-go: don't force space after "//" in comments (#725)
  > protoc-gen-go/generator: fix misspelling (#732)
  >  .travis.yml: include go1.11 (#731)
  > protoc-gen-go: only disambiguate predefined idents for local package names (#724)
  > protoc-gen-go: predeclared identifiers in cleanPackageName (#722)
  > protoc-gen-go: put all imports in one section (#720)
  > protoc-gen-go: more standard import organization (#719)
  > protoc-gen-go: generate descriptor before plugins (#718)
  > protoc-gen-go: simplify init function generation (#716)
  > protoc-gen-go: move package comments to before the package decl (#715)
  > protoc-gen-go: fix symbol names in comments on public imports
  > protoc-gen-go: additional tests for public imports
  > protoc-gen-go: Don't set the json tag on extension fields. (#713)
  > protoc-gen-go: add more spaces between methods (#712)
  > protoc-gen-go: add blank line after extension method (#711)
  > protoc-gen-go: put imports in a single import() block (#707)
  > proto: remove commented-out code (#704)
  > proto: replace exprs with matching consts from math pkg (#705)
  > proto: replace len(b)<=0 with len(b)==0 (#706)
  > protoc-gen-go: stop generating package "// import" comment (#701)
  > protoc-gen-go: use consistent receiver name for messages (#700)
  > go.mod: add module file (#699)
  > protoc-gen-go: add blank lines between various enum functions (#697)
  > proto: uniquify descriptor var based on filename alone (#696)
  > proto: deprecate Stats data structure (#677)
  > proto: return more useful error message in SetExtension (#685)
  > proto: fix handling of required fields after multiple violations (#679)
  > Update issue templates
  > README.md: remove usage of group in example (#673)
  > jsonpb: avoid unexported fields in hand-crafted message (#671)
  > proto: make invalid UTF-8 errors non-fatal (#660)
  > jsonpb: strictly document JSONPBMarshaler and JSONPBUnmarshaler behavior (#662)
  > proto: revert strict erroring of deterministic and custom marshalers (#658)
  > protoc-gen-go: refactor generator by splitting up generateMessage (#657)
  > proto: fix and cleanup test for deterministic marshal with custom marshalers (#656)
  > jsonpb: avoid copying string-valued map-keys (#654)
  > proto: return errors when using deterministic marshaling with custom Marshalers
  > README: fix markdown formatting issue
  > proto: fix quadratic behavior in nested map marshaling (#641)
  > jsonpb: handle map key and value properties properly (#645)
  > jsonpb: decode int32/uint32/float32/float64 strings (#630)
  > ptypes: ran gofmt on any_test.go
  > Build grpc generated code as part of tests (#634)
  > proto: revert UTF-8 validation for proto2 (#628)
  > jsonpb: error on scalar enum provided for repeated enums instead of panic
  > proto: mention field name in error message (#616)
  > jsonpb: fix unmarshaling JSON object with escaped string into Struct type (#612)
  > grpc: fix and improve interface comments for client/server types (#604)
  > LICENSE: Move title to README.md
  > proto: adjust documentation on RequiredNotSetError (#603)
  > grpc: document ctx closure best practices (#600)
  > protoc-gen-go: remove deprecated function in grpc (#592) (#602)
  > ptypes: optimize Is to avoid prefix scan (#601)

Co-authored-by: Amin Jamali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emalm @cfdreddbot @cf-gitbot @jfmyers9