-
Notifications
You must be signed in to change notification settings - Fork 218
[WIP] Remove Consul #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[WIP] Remove Consul #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule src/code.cloudfoundry.org/auctioneer 0f34bdf..df86f95aa: > remove consul configs; kill locket after killing auctioneer > wip: auctioneer tests pass and consul has been removed > Initial work on removing consul from autioneer: > Remove consul-related configs from auctioneer config Submodule src/code.cloudfoundry.org/bbs 3a12fde..6d44a4df0: > wip: remove CellRegistrationsLocketEnabled and LocksLocketEnabled > wip: remove consul from config > wip: remove consul from serviceclient > wip: invoke lock runner correctly > wip, replacing consulHelper with locketHelper > wip, replacing consulHelper with locketHelper > wip, removing consul from bbs > Add Mysql8 Test helper Submodule src/code.cloudfoundry.org/diego-ssh 71ed07f..0ff25b97a: > wip: remove consul from config > wip: update test with ext-info-c algo > wip: remove the rest of consul > wip: initial work, 1 test failing for unknown reasons Submodule src/code.cloudfoundry.org/fileserver 45d4926..11af6ea: > removing consul from fileserver Submodule src/code.cloudfoundry.org/locket a21aad283..933b89909: > Remove consul Submodule src/code.cloudfoundry.org/rep 1029eba..aa84ac0fc: > wip removing consul configs from bbs in test > Don't start a new locket in main_test > wip, contining to remove consul from rep > Initial work on removing consul from rep > Remove consul-related properties from rep config
do not keep this later! Signed-off-by: Josh Russett <[email protected]>
Submodule src/code.cloudfoundry.org/route-emitter ce7eb78..7fc0b67fa: > wip: begin removing consul from cmd/route-emitter and main tests > wip: remove from config > wip: remove consuldownchecker/notifier
Submodule src/code.cloudfoundry.org/route-emitter 7fc0b67fa..447eb5d80: > wip: remove consul from route-emitter Signed-off-by: Brandon Roberson <[email protected]>
- Remove references in the job specs and templates - Remove unnecessary bosh job templates - Updates some docs Signed-off-by: Brandon Roberson <[email protected]>
This reverts commit 80fbff8.
|
ameowlia
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fake approve
Submodule src/code.cloudfoundry.org/executor f08814ac5..d736a8a3a: > pprof: explicitly start http server on 6060
This reverts commit 1e01342.
Submodule src/code.cloudfoundry.org/executor f08814ac5..59b23ec49: > Change pprof output file name > Revert "pprof: explicitly start http server on 6060" > pprof: explicitly start http server on 6060
Submodule src/code.cloudfoundry.org/executor 59b23ec49..807dbbcf4: > Revert "Revert "pprof: explicitly start http server on 6060""
Submodule src/code.cloudfoundry.org/executor 807dbbcf4..2b06fc8a9: > close the io.Writer
Signed-off-by: Brandon Roberson <[email protected]>
Signed-off-by: Brandon Roberson <[email protected]>
…y directory Signed-off-by: Brandon Roberson <[email protected]>
- test.sh: Runs unit tests. If provided package names as arguments, it will test only those packages. This script assumes that it is being run inside a docker container. Do not run directly. - docker-shell: Starts a docker container and runs the provided executable. - docker-test: Uses docker-shell and test.sh to run unit tests inside a docker container that provides all of the necessary mount points, environment variables, and database services to successfully run the tests Signed-off-by: David Sabeti <[email protected]>
…ker container starts Signed-off-by: Brandon Roberson <[email protected]>
Signed-off-by: David Sabeti <[email protected]>
Signed-off-by: Josh Russett <[email protected]>
Signed-off-by: Brandon Roberson <[email protected]>
Signed-off-by: Josh Russett <[email protected]>
Signed-off-by: Josh Russett <[email protected]>
Submodule src/code.cloudfoundry.org/rep aa84ac0fc..8f1cd3c36: > Ensure locket and BBS test services exit properly > Regenerate fixture certs + update regen script Submodule src/code.cloudfoundry.org/route-emitter a224b9416..b83ba7c9a: > Ensure that locket process stops in AfterEach > Regenerate certs + regen script Signed-off-by: Brandon Roberson <[email protected]>
Removing unneeded scripts Signed-off-by: Josh Russett <[email protected]> Signed-off-by: Brandon Roberson <[email protected]>
Signed-off-by: Josh Russett <[email protected]>
Signed-off-by: Josh Russett <[email protected]>
Submodule src/code.cloudfoundry.org/route-emitter b83ba7c9a..686b069f9: > Allow nats-client 60 seconds to start-up Signed-off-by: Josh Russett <[email protected]>
Submodule src/code.cloudfoundry.org/auctioneer df86f95aa...7b69d26e0: > Remove consul from auctioneer < remove consul configs; kill locket after killing auctioneer < wip: auctioneer tests pass and consul has been removed < Initial work on removing consul from autioneer: < Remove consul-related configs from auctioneer config Submodule src/code.cloudfoundry.org/bbs 6d44a4df0...f7f79acea: > Merge branch 'remove-consul' > Ginkgo v2: don't use Done channels < wip: remove CellRegistrationsLocketEnabled and LocksLocketEnabled < wip: remove consul from config < wip: remove consul from serviceclient < wip: invoke lock runner correctly < wip, replacing consulHelper with locketHelper < wip, replacing consulHelper with locketHelper < wip, removing consul from bbs Submodule src/code.cloudfoundry.org/diego-ssh 0ff25b97a...0fc4f3a7d: > Remove consul from diego-ssh < wip: remove consul from config < wip: update test with ext-info-c algo < wip: remove the rest of consul < wip: initial work, 1 test failing for unknown reasons Submodule src/code.cloudfoundry.org/inigo 3c043a775...9179fa241: > Remove consul from Inigo + tests < Fix inigo tests now that consul was removed - needed better locket references < remove consul references from inigo Submodule src/code.cloudfoundry.org/locket c6ad4e78e...76a930295: > Remove consul < Update readme with removal of consul client < Remove consul Submodule src/code.cloudfoundry.org/rep 8f1cd3c36...ff647de01: > Remove consul from Rep < Ensure locket and BBS test services exit properly < Regenerate fixture certs + update regen script < wip removing consul configs from bbs in test < Don't start a new locket in main_test < wip, contining to remove consul from rep < Initial work on removing consul from rep < Remove consul-related properties from rep config Signed-off-by: Josh Russett <[email protected]> Co-authored-by: Josh Russett <[email protected]>
- go mod tidy and go mod vendor Signed-off-by: Renee Chu <[email protected]>
Submodule src/code.cloudfoundry.org/route-emitter 686b069f9...ff7d17216: > Remove consul from route-emitter < Allow nats-client 60 seconds to start-up < Ensure that locket process stops in AfterEach < Regenerate certs + regen script < give NATS time to start up before checking if it is actually up > Switch to go-uaa from uaa-go-client (#17) < wip: remove consul from route-emitter < wip: begin removing consul from cmd/route-emitter and main tests < wip: remove from config < wip: remove consuldownchecker/notifier Signed-off-by: Josh Russett <[email protected]> Signed-off-by: Renee Chu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS YET!
Creating a PR for this branch so CI can perform testing on it before commit cleanup is done.