Skip to content

Conversation

@geofffranks
Copy link
Contributor

DO NOT MERGE THIS YET!

Creating a PR for this branch so CI can perform testing on it before commit cleanup is done.

jrussett and others added 15 commits September 30, 2022 22:43
Submodule src/code.cloudfoundry.org/auctioneer 0f34bdf..df86f95aa:
  > remove consul configs; kill locket after killing auctioneer
  > wip: auctioneer tests pass and consul has been removed
  > Initial work on removing consul from autioneer:
  > Remove consul-related configs from auctioneer config
Submodule src/code.cloudfoundry.org/bbs 3a12fde..6d44a4df0:
  > wip: remove CellRegistrationsLocketEnabled and LocksLocketEnabled
  > wip: remove consul from config
  > wip: remove consul from serviceclient
  > wip: invoke lock runner correctly
  > wip, replacing consulHelper with locketHelper
  > wip, replacing consulHelper with locketHelper
  > wip, removing consul from bbs
  > Add Mysql8 Test helper
Submodule src/code.cloudfoundry.org/diego-ssh 71ed07f..0ff25b97a:
  > wip: remove consul from config
  > wip: update test with ext-info-c algo
  > wip: remove the rest of consul
  > wip: initial work, 1 test failing for unknown reasons
Submodule src/code.cloudfoundry.org/fileserver 45d4926..11af6ea:
  > removing consul from fileserver
Submodule src/code.cloudfoundry.org/locket a21aad283..933b89909:
  > Remove consul
Submodule src/code.cloudfoundry.org/rep 1029eba..aa84ac0fc:
  > wip removing consul configs from bbs in test
  > Don't start a new locket in main_test
  > wip, contining to remove consul from rep
  > Initial work on removing consul from rep
  > Remove consul-related properties from rep config
do not keep this later!

Signed-off-by: Josh Russett <[email protected]>
Submodule src/code.cloudfoundry.org/route-emitter ce7eb78..7fc0b67fa:
  > wip: begin removing consul from cmd/route-emitter and main tests
  > wip: remove from config
  > wip: remove consuldownchecker/notifier
Submodule src/code.cloudfoundry.org/route-emitter 7fc0b67fa..447eb5d80:
  > wip: remove consul from route-emitter

Signed-off-by: Brandon Roberson <[email protected]>
- Remove references in the job specs and templates
- Remove unnecessary bosh job templates
- Updates some docs

Signed-off-by: Brandon Roberson <[email protected]>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 21, 2022

CLA Not Signed

@ameowlia ameowlia self-requested a review October 21, 2022 20:04
Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fake approve

reneighbor and others added 8 commits October 24, 2022 19:04
Submodule src/code.cloudfoundry.org/executor f08814ac5..d736a8a3a:
  > pprof: explicitly start http server on 6060
This reverts commit 1e01342.
Submodule src/code.cloudfoundry.org/executor f08814ac5..59b23ec49:
  > Change pprof output file name
  > Revert "pprof: explicitly start http server on 6060"
  > pprof: explicitly start http server on 6060
Submodule src/code.cloudfoundry.org/executor 59b23ec49..807dbbcf4:
  > Revert "Revert "pprof: explicitly start http server on 6060""
Submodule src/code.cloudfoundry.org/executor 807dbbcf4..2b06fc8a9:
  > close the io.Writer
reneighbor and others added 3 commits November 1, 2022 20:37
Signed-off-by: Brandon Roberson <[email protected]>
Signed-off-by: Brandon Roberson <[email protected]>
ebroberson and others added 14 commits November 4, 2022 16:43
- test.sh: Runs unit tests. If provided package names as arguments, it will test only those packages. This script assumes that it is being run inside a docker container. Do not run directly.
- docker-shell: Starts a docker container and runs the provided executable.
- docker-test: Uses docker-shell and test.sh to run unit tests inside a docker container that provides all of the necessary mount points, environment variables, and database services to successfully run the tests

Signed-off-by: David Sabeti <[email protected]>
Signed-off-by: Brandon Roberson <[email protected]>
Submodule src/code.cloudfoundry.org/rep aa84ac0fc..8f1cd3c36:
  > Ensure locket and BBS test services exit properly
  > Regenerate fixture certs + update regen script
Submodule src/code.cloudfoundry.org/route-emitter a224b9416..b83ba7c9a:
  > Ensure that locket process stops in AfterEach
  > Regenerate certs + regen script

Signed-off-by: Brandon Roberson <[email protected]>
Removing unneeded scripts

Signed-off-by: Josh Russett <[email protected]>
Signed-off-by: Brandon Roberson <[email protected]>
Submodule src/code.cloudfoundry.org/route-emitter b83ba7c9a..686b069f9:
  > Allow nats-client 60 seconds to start-up

Signed-off-by: Josh Russett <[email protected]>
@jrussett jrussett closed this Nov 9, 2022
@jrussett jrussett reopened this Nov 9, 2022
ebroberson and others added 3 commits November 10, 2022 21:27
Submodule src/code.cloudfoundry.org/auctioneer df86f95aa...7b69d26e0:
  > Remove consul from auctioneer
  < remove consul configs; kill locket after killing auctioneer
  < wip: auctioneer tests pass and consul has been removed
  < Initial work on removing consul from autioneer:
  < Remove consul-related configs from auctioneer config
Submodule src/code.cloudfoundry.org/bbs 6d44a4df0...f7f79acea:
  > Merge branch 'remove-consul'
  > Ginkgo v2: don't use Done channels
  < wip: remove CellRegistrationsLocketEnabled and LocksLocketEnabled
  < wip: remove consul from config
  < wip: remove consul from serviceclient
  < wip: invoke lock runner correctly
  < wip, replacing consulHelper with locketHelper
  < wip, replacing consulHelper with locketHelper
  < wip, removing consul from bbs
Submodule src/code.cloudfoundry.org/diego-ssh 0ff25b97a...0fc4f3a7d:
  > Remove consul from diego-ssh
  < wip: remove consul from config
  < wip: update test with ext-info-c algo
  < wip: remove the rest of consul
  < wip: initial work, 1 test failing for unknown reasons
Submodule src/code.cloudfoundry.org/inigo 3c043a775...9179fa241:
  > Remove consul from Inigo + tests
  < Fix inigo tests now that consul was removed - needed better locket references
  < remove consul references from inigo
Submodule src/code.cloudfoundry.org/locket c6ad4e78e...76a930295:
  > Remove consul
  < Update readme with removal of consul client
  < Remove consul
Submodule src/code.cloudfoundry.org/rep 8f1cd3c36...ff647de01:
  > Remove consul from Rep
  < Ensure locket and BBS test services exit properly
  < Regenerate fixture certs + update regen script
  < wip removing consul configs from bbs in test
  < Don't start a new locket in main_test
  < wip, contining to remove consul from rep
  < Initial work on removing consul from rep
  < Remove consul-related properties from rep config

Signed-off-by: Josh Russett <[email protected]>
Co-authored-by: Josh Russett <[email protected]>
- go mod tidy and go mod vendor

Signed-off-by: Renee Chu <[email protected]>
Submodule src/code.cloudfoundry.org/route-emitter 686b069f9...ff7d17216:
  > Remove consul from route-emitter
  < Allow nats-client 60 seconds to start-up
  < Ensure that locket process stops in AfterEach
  < Regenerate certs + regen script
  < give NATS time to start up before checking if it is actually up
  > Switch to go-uaa from uaa-go-client (#17)
  < wip: remove consul from route-emitter
  < wip: begin removing consul from cmd/route-emitter and main tests
  < wip: remove from config
  < wip: remove consuldownchecker/notifier

Signed-off-by: Josh Russett <[email protected]>
Signed-off-by: Renee Chu <[email protected]>
@reneighbor reneighbor closed this Nov 21, 2022
@jrussett jrussett deleted the remove-consul branch March 15, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants