Skip to content

Conversation

@jrussett
Copy link
Contributor

bumps submodules: auctioneer bbs diego-ssh fileserver locket rep route-emitter cfdot

  • Remove references in the job specs and templates
  • Remove unnecessary bosh job templates
  • Updates some docs

Scripts:
Make scripts/check-metrics-documentation function when called from any directory

Add new scripts for running unit tests in local docker containers

  • test.sh: Runs unit tests. If provided package names as arguments, it will test only those packages. This script assumes that it is being run inside a docker container. Do not run directly.
  • docker-shell: Starts a docker container and runs the provided executable.
  • docker-test: Uses docker-shell and test.sh to run unit tests inside a docker container that provides all of the necessary mount points, environment variables, and database services to successfully run the tests

Use smart defaults for databases

Signed-off-by: Josh Russett [email protected]
Signed-off-by: Brandon Roberson [email protected]
Signed-off-by: Renee Chu [email protected]
Signed-off-by: David Sabeti [email protected]

Thank you for submitting a pull request to the diego-release repository. We appreciate the contribution. To help us with getting better context for the pull request please follow these guidelines:

Please make sure to complete the following steps

  • Before PR Submission, Submit an issue for either an Enhancement or Bug
  • Check the Contributing document on how to sign the CLA and run tests in diego-release.
  • Make sure a pull request is done against the develop branch.

Issue Link

Please link the issue you created above for a bug or enhancement.

Thank you!

bumps submodules: auctioneer bbs diego-ssh fileserver locket rep route-emitter cfdot

- Remove references in the job specs and templates
- Remove unnecessary bosh job templates
- Updates some docs

Scripts:
Make scripts/check-metrics-documentation function when called from any directory

Add new scripts for running unit tests in local docker containers

- test.sh: Runs unit tests. If provided package names as arguments, it will test only those packages. This script assumes that it is being run inside a docker container. Do not run directly.
- docker-shell: Starts a docker container and runs the provided executable.
- docker-test: Uses docker-shell and test.sh to run unit tests inside a docker container that provides all of the necessary mount points, environment variables, and database services to successfully run the tests

Use smart defaults for databases

Signed-off-by: Josh Russett <[email protected]>
Signed-off-by: Brandon Roberson <[email protected]>
Signed-off-by: Renee Chu <[email protected]>
Signed-off-by: David Sabeti <[email protected]>
@jrussett jrussett requested a review from reneighbor November 21, 2022 21:10
Copy link
Contributor

@reneighbor reneighbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@ebroberson ebroberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants