Use native x509 package instead of custom systemcerts #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofffranks
approved these changes
Aug 25, 2023
jrussett
added a commit
that referenced
this pull request
Aug 25, 2023
This is a follow up to: #808 We don't need to sync code.cloudfoundry.org/systemcerts anymore because we removed it. Fixes: ``` + ./scripts/sync-submodule-config + export PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin + PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin + mkdir -p bin + cd src/gosub + go build -o ../../bin/gosub . + FORCE_SUBMODULE_HTTPS=true + rm -rf /tmp/packages + cat + cat /tmp/packages + xargs -s 1048576 gosub sync --force-https=true failed to get dependency repo: chdir /tmp/build/a22dd28d/diego-release/src/code.cloudfoundry.org/systemcerts: no such file or directory ``` [#184870112](https://www.pivotaltracker.com/story/show/184870112)
ameowlia
pushed a commit
that referenced
this pull request
Aug 25, 2023
This is a follow up to: #808 We don't need to sync code.cloudfoundry.org/systemcerts anymore because we removed it. Fixes: ``` + ./scripts/sync-submodule-config + export PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin + PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin + mkdir -p bin + cd src/gosub + go build -o ../../bin/gosub . + FORCE_SUBMODULE_HTTPS=true + rm -rf /tmp/packages + cat + cat /tmp/packages + xargs -s 1048576 gosub sync --force-https=true failed to get dependency repo: chdir /tmp/build/a22dd28d/diego-release/src/code.cloudfoundry.org/systemcerts: no such file or directory ``` [#184870112](https://www.pivotaltracker.com/story/show/184870112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodule src/code.cloudfoundry.org/cacheddownloader 55ed57674..fe2e12402:
Accepted by performing the following:
tls: failed to verify certificate: x509: certificate signed by unknown authorityImport-Certificate -FilePath C:\var\vcap\server.pem -CertStoreLocation Cert:\LocalMachine\Root\Please make sure to complete the following steps
developbranch.Thank you!