Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workers-shared): use version range instead of tag to avoid issues with changesets CI #7331

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Nov 25, 2024

Fixes n/a.

#7303 used the latest tag to avoid circular dependency error with turborepo (e.g. this). However, this breaks our changesets CI job as it fails to resolve the latest tag version. (e.g. this).

This PR replaces the latest tag with a caret version range to avoid the issue above.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: ci fix
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: ci fix
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: ci fix

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: b2711d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@edmundhung edmundhung changed the title chore: fix chore: fix changeset version error Nov 25, 2024
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-wrangler-7331

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7331/npm-package-wrangler-7331

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-wrangler-7331 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-create-cloudflare-7331 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-cloudflare-kv-asset-handler-7331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-miniflare-7331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-cloudflare-pages-shared-7331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-cloudflare-vitest-pool-workers-7331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-cloudflare-workers-editor-shared-7331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-cloudflare-workers-shared-7331
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12012215987/npm-package-cloudflare-workflows-shared-7331

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung changed the title chore: fix changeset version error chore(workers-shared): use version range instead of tag to avoid issues with changesets CI Nov 25, 2024
@edmundhung edmundhung marked this pull request as ready for review November 25, 2024 14:49
@edmundhung edmundhung requested a review from a team as a code owner November 25, 2024 14:49
@edmundhung edmundhung merged commit 37b3ccc into main Nov 25, 2024
36 of 41 checks passed
@edmundhung edmundhung deleted the edmundhung/workers-shared-circular-dependency branch November 25, 2024 15:42
emily-shen added a commit that referenced this pull request Nov 26, 2024
…oid issues with changesets CI (#7331)"

This reverts commit 37b3ccc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants