Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify router-worker logic to allow for running user-worker ahead of assets #7303

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Nov 20, 2024

This PR provides the option for user worker to run ahead of assets.

  • Adds logic to run user-worker ahead of assets
  • Moves vitest from worker-shared root into asset-worker
  • Creates new vitest unit test suite for router-worker

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not user facing through this mechanism

@WillTaylorDev WillTaylorDev requested review from a team as code owners November 20, 2024 16:12
Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 784e82f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/workers-shared Minor
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/run-user-worker-ahead-assets branch from 34432e0 to d322e79 Compare November 20, 2024 16:16
Copy link
Contributor

github-actions bot commented Nov 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-wrangler-7303

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7303/npm-package-wrangler-7303

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-wrangler-7303 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-create-cloudflare-7303 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-cloudflare-kv-asset-handler-7303
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-miniflare-7303
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-cloudflare-pages-shared-7303
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-cloudflare-vitest-pool-workers-7303
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-cloudflare-workers-editor-shared-7303
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-cloudflare-workers-shared-7303
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974253179/npm-package-cloudflare-workflows-shared-7303

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/run-user-worker-ahead-assets branch from d322e79 to 03009f3 Compare November 20, 2024 16:27
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/run-user-worker-ahead-assets branch 2 times, most recently from 3ab8173 to a3d1d4e Compare November 20, 2024 17:39
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/run-user-worker-ahead-assets branch from a3d1d4e to 4eb8376 Compare November 22, 2024 12:51
…assets

- Adds logic to run user-worker ahead of assets
- Moves vitest from worker-shared root into asset-worker
- Creates new vitest unit suite for router-worker
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/run-user-worker-ahead-assets branch from 4eb8376 to 784e82f Compare November 22, 2024 14:14
@WillTaylorDev WillTaylorDev merged commit 0d314ed into main Nov 22, 2024
30 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/run-user-worker-ahead-assets branch November 22, 2024 17:32
emily-shen added a commit that referenced this pull request Nov 26, 2024
@lrapoport-cf lrapoport-cf mentioned this pull request Nov 26, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants