Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restrict changeset version bump to workspace protocol only #7335

Merged

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Nov 25, 2024

Fixes #7331

In #7331, we replaced the latest tag with a caret version range to avoid an issue on changeset which fails to resolve the latest tag version for comparsion. However, it doesn't solve the issue completely as changeset attempts to bump the version in the CI regardless and fails updating the pnpm lockfile with the following error meesage:

 ERR_PNPM_NO_MATCHING_VERSION  No matching version found for @cloudflare/vitest-pool-workers@^0.5.32

This error happened while installing a direct dependency of /Users/edmund/Workspace/workers-sdk/packages/workers-shared

The latest release of @cloudflare/vitest-pool-workers is "0.5.31".

If you need the full list of all 97 published versions run "$ pnpm view @cloudflare/vitest-pool-workers versions".
Progress: resolved 231, reused 0, downloaded 0
node:child_process:965
    throw err;
    ^

Error: Command failed: pnpm install --lockfile-only

This PR resolves the issue by restricting changesets to only bump package versions specified with the workspace protocol. (changesets/changesets#507).


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: ci fix
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: ci fix
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: ci fix

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: fc3bf21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-wrangler-7335

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7335/npm-package-wrangler-7335

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-wrangler-7335 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-create-cloudflare-7335 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-cloudflare-kv-asset-handler-7335
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-miniflare-7335
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-cloudflare-pages-shared-7335
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-cloudflare-vitest-pool-workers-7335
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-cloudflare-workers-editor-shared-7335
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-cloudflare-workers-shared-7335
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12014609016/npm-package-cloudflare-workflows-shared-7335

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung merged commit 5cdf2a6 into main Nov 25, 2024
35 of 39 checks passed
@edmundhung edmundhung deleted the edmundhung/restrict-version-bump-to-workspace-protocol-only branch November 25, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants