-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor wrangler login/logout/whoami
to use defineCommand
#7150
Conversation
🦋 Changeset detectedLatest commit: ec6d4cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-wrangler-7150 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7150/npm-package-wrangler-7150 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-wrangler-7150 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-create-cloudflare-7150 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-cloudflare-kv-asset-handler-7150 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-miniflare-7150 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-cloudflare-pages-shared-7150 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-cloudflare-vitest-pool-workers-7150 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-cloudflare-workers-editor-shared-7150 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-cloudflare-workers-shared-7150 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11670128969/npm-package-cloudflare-workflows-shared-7150 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
wrangler login/logout/whoami
to use defineCommandwrangler login/logout/whoami/types
to use defineCommand
wrangler login/logout/whoami/types
to use defineCommandwrangler login/logout/whoami
to use defineCommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things, but otherwise ✅
Co-authored-by: Somhairle MacLeòid <[email protected]>
45dbaa5
to
a3ec8ea
Compare
09d22d3
to
54d2163
Compare
/** | ||
* By default, wrangler will print warnings about wrangler.toml configuration. | ||
* Set this value to `false` to skip printing these warnings. | ||
*/ | ||
printConfigWarnings?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was rebasing the changes on #6756 over to this PR and notice the same changes doesn't work here. The reason was that defineCommand
will read the config for you and there was no way to disable the warning. You can find the full changes that enable this option in ec6d4cd
cc: @penalosa @emily-shen
Fixes #N/A
Landing #6655 in smaller chunks. This one does
wrangler login/logout/whoami
. There should be no functionality change.