Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warnings for invalid config in wrangler login & logout #6756

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

WalshyDev
Copy link
Member

What this PR solves / how to test

Fixes WO-184

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no changes
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no public changes

@WalshyDev WalshyDev requested a review from a team as a code owner September 18, 2024 22:15
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 8e521b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 18, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-wrangler-6756

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6756/npm-package-wrangler-6756

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-wrangler-6756 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-create-cloudflare-6756 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-kv-asset-handler-6756
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-miniflare-6756
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-pages-shared-6756
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-vitest-pool-workers-6756
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-workers-editor-shared-6756
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-workers-shared-6756
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-workflows-shared-6756

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev force-pushed the walshy/disable-warnings-on-login-logout branch from 7be53b2 to f6a274e Compare September 18, 2024 22:20
@penalosa
Copy link
Contributor

I'm not sure I understand the intention here—in this case there is an invalid wrangler.toml file, and I think we do want to warn. It's not a hard error, so this shouldn't be causing user issues

@WalshyDev
Copy link
Member Author

Yeah but warning on an invalid wrangler.toml during login/logout just doesn't make much sense - we read it just for the metrics value but we don't use anything else.

A user seeing a warning after logging in is confusing.

@threepointone
Copy link
Contributor

Actually a good idea, I like it

@emily-shen emily-shen force-pushed the walshy/disable-warnings-on-login-logout branch from f6a274e to 8e521b3 Compare October 29, 2024 15:17
@penalosa
Copy link
Contributor

penalosa commented Nov 4, 2024

For context, I had originally blocked this because I had thought that config being invalid could potentially cause weird behaviour in login, primarily around the account_id field. Having read the PR more closely, since we're only reading config after actually logging in or out that concern is removed. Thanks @WalshyDev for this!

@edmundhung edmundhung merged commit 49ef163 into main Nov 4, 2024
21 checks passed
@edmundhung edmundhung deleted the walshy/disable-warnings-on-login-logout branch November 4, 2024 15:32
@workers-devprod workers-devprod mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants