-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable warnings for invalid config in wrangler login & logout #6756
Conversation
🦋 Changeset detectedLatest commit: 8e521b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-wrangler-6756 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6756/npm-package-wrangler-6756 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-wrangler-6756 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-create-cloudflare-6756 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-kv-asset-handler-6756 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-miniflare-6756 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-pages-shared-6756 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-vitest-pool-workers-6756 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-workers-editor-shared-6756 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-workers-shared-6756 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11576974580/npm-package-cloudflare-workflows-shared-6756 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
7be53b2
to
f6a274e
Compare
I'm not sure I understand the intention here—in this case there is an invalid |
Yeah but warning on an invalid wrangler.toml during login/logout just doesn't make much sense - we read it just for the metrics value but we don't use anything else. A user seeing a warning after logging in is confusing. |
Actually a good idea, I like it |
f6a274e
to
8e521b3
Compare
For context, I had originally blocked this because I had thought that config being invalid could potentially cause weird behaviour in login, primarily around the |
What this PR solves / how to test
Fixes WO-184
Author has addressed the following