Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all commands to use new registration utils #6655

Closed
wants to merge 24 commits into from

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Sep 9, 2024

What this PR solves / how to test

WIP

  • wrangler docs
  • wrangler init
  • wrangler dev
  • wrangler deploy
  • wrangler deployments
  • wrangler rollback
  • wrangler versions
  • wrangler triggers
  • wrangler delete
  • wrangler tail
  • wrangler secret
  • wrangler types
  • wrangler kv
  • wrangler queues
  • wrangler r2
  • wrangler d1
  • wrangler vectorize
  • wrangler hyperdrive
  • wrangler pages
  • wrangler mtls-certificate
  • wrangler pubsub
  • wrangler dispatch-namespace
  • wrangler ai
  • wrangler login
  • wrangler logout
  • wrangler whoami

Keeping note of things to fix:

  • respect order of alias definitions (in help output)
  • allow alias command description to be overridden with (Hook?) access to real definition metadata

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: 8361f5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 9, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-wrangler-6655

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6655/npm-package-wrangler-6655

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-wrangler-6655 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-create-cloudflare-6655 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-cloudflare-kv-asset-handler-6655
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-miniflare-6655
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-cloudflare-pages-shared-6655
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-cloudflare-vitest-pool-workers-6655
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-cloudflare-workers-editor-shared-6655
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10792048971/npm-package-cloudflare-workers-shared-6655

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas RamIdeas changed the title Register all commands to use new registration utils Refactor all commands to use new registration utils Sep 9, 2024
@penalosa
Copy link
Contributor

Closing—we'll be landing this as incremental command-by-command PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants