Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the framework name #7109

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Rename the framework name #7109

merged 3 commits into from
Nov 7, 2024

Conversation

jsparkdev
Copy link
Contributor

@jsparkdev jsparkdev commented Oct 28, 2024

The name currently displayed in the CLI is Svelte. However, all of the options actually create a SvelteKit app, and the name SvelteKit is also used in the documentation.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: only display name change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: it matches existing features with documentation.

@jsparkdev jsparkdev requested review from a team as code owners October 28, 2024 04:32
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 9382b80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the PR @jsparkdev 🙂

However I think that this is a duplicate of #6565

Also this has been an issue for a while: #3263 I think we should definitely clarify things 😕 (personally I think we should indeed go with SvelteKit instead of Svelte, but I am not sure if I can make the call all by myself... it's probably something I need to check with the team)

cc. @penalosa

@jsparkdev
Copy link
Contributor Author

@dario-piotrowicz

Thank you! That's a lot of discussion!

So, do you think it's a good idea to close this PR?

@dario-piotrowicz
Copy link
Member

Hey @jsparkdev 🙂

yeah closing this PR is what I was thinking but @penalosa's PR is a bit outdated now and I think they will not be available in the next few days... so might be worth it to keep going with this PR? 🤔

Let me just check with the team, if there are no objections regarding the renaming I'd go forward with this one maybe 🤔

@jsparkdev
Copy link
Contributor Author

@dario-piotrowicz Thanks for the kind explanation. I'll keep this PR then :)

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

github-actions bot commented Nov 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-wrangler-7109

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7109/npm-package-wrangler-7109

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-wrangler-7109 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-create-cloudflare-7109 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-kv-asset-handler-7109
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-miniflare-7109
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-pages-shared-7109
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-vitest-pool-workers-7109
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-workers-editor-shared-7109
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-workers-shared-7109
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-workflows-shared-7109

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu added the e2e Run e2e tests on a PR label Nov 7, 2024
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much @jsparkdev for making wrangler better ♥️

@CarmenPopoviciu CarmenPopoviciu merged commit 492533f into cloudflare:main Nov 7, 2024
59 of 80 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Nov 7, 2024
Copy link

holopin-bot bot commented Nov 7, 2024

Congratulations @jsparkdev, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm37gecl883900cjlohizd7dd

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants