-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the framework name #7109
Conversation
🦋 Changeset detectedLatest commit: 9382b80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch for the PR @jsparkdev 🙂
However I think that this is a duplicate of #6565
Also this has been an issue for a while: #3263 I think we should definitely clarify things 😕 (personally I think we should indeed go with SvelteKit
instead of Svelte
, but I am not sure if I can make the call all by myself... it's probably something I need to check with the team)
cc. @penalosa
Thank you! That's a lot of discussion! So, do you think it's a good idea to close this PR? |
Hey @jsparkdev 🙂 yeah closing this PR is what I was thinking but @penalosa's PR is a bit outdated now and I think they will not be available in the next few days... so might be worth it to keep going with this PR? 🤔 Let me just check with the team, if there are no objections regarding the renaming I'd go forward with this one maybe 🤔 |
@dario-piotrowicz Thanks for the kind explanation. I'll keep this PR then :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-wrangler-7109 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7109/npm-package-wrangler-7109 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-wrangler-7109 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-create-cloudflare-7109 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-kv-asset-handler-7109 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-miniflare-7109 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-pages-shared-7109 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-vitest-pool-workers-7109 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-workers-editor-shared-7109 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-workers-shared-7109 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11547396716/npm-package-cloudflare-workflows-shared-7109 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much @jsparkdev for making wrangler better
Congratulations @jsparkdev, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm37gecl883900cjlohizd7dd This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
The name currently displayed in the CLI is
Svelte
. However, all of the options actually create aSvelteKit
app, and the nameSvelteKit
is also used in the documentation.