-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 BUG: C3's Svelte option is really SvelteKit - confusing? #3263
Comments
I just wanted to add that this doesn't only apply to Svelte/SvelteKit but to other frameworks/meta-frameworks as well such as qwik/qwikCity and solid/solidStart Regardless on whether this is right or potentially confusing and whether it should be changed or not, one thing that I think important here is to keep this consistent with our docs, those currently use the same pattern as C3 does: https://developers.cloudflare.com/pages/framework-guides/ (saying |
Hi 👋 Svelte/SvelteKit maintainer here. I just happened to stumble across this while looking for open issues mentioning SvelteKit to see how we can better support Cloudflare. They way we think about it is if you create a new Svelte app that should be a SvelteKit app, but we should also be clear about what's Svelte vs SvelteKit. So we have I'd also love to connect regarding ways to have SvelteKit and Vite apps work better with wrangler and vice versa. I have to run to a meeting at the moment, but might leave some thoughts here later unless there's a better place to discuss. |
Following up on this, SvelteKit is based on Vite. To run a SvelteKit app for local development you run |
@benmccann the local dev situation with Cloudflare and vite dev servers is something that we've been exploring recently As part of that I've also opened this PR in the SvelteKit repo: sveltejs/kit#11323 (which isn't really having much success I must say 😓) (which you commented on 😜) I've sent you a friend invite on discord, you can also join the Cloudflare server, if you want let's connect there and discuss how we can better the local dev situation for developers! 🙂 |
Per #3263 (comment), this is what the Svelte team recommends. The Svelte framework template runs `create-svelte` which scaffolds a SvelteKit project, so this should make it clearer to users what type of project they're actually going to get.
This was addressed by #7109 |
Which Cloudflare product(s) does this pertain to?
C3
What version of
Wrangler
are you using?2.0.2
What operating system are you using?
all
Describe the Bug
I'm filing this mostly for posterity and record keeping.
In https://twitter.com/mr_wormhole/status/1658940824468480003 Talha pointed out that we are missing SvelteKit support.
Initially I thought this was a bug, but it turns out that what we call "Svelte" translates to
create-svelte
npm package which scaffolds a SvelteKit app.My read on this is that we did the right thing: our guiding principle is that we enable full fidelity of UX/DX control for the framework authors. That includes branding. In this situation that means that we should honor that the Svelte/SvelteKit team decided to call their DX entry-point to scaffolding applications
create-svelte
which represents Svelte and not SvelteKit.If the SvelteKit team would like to be represented differently then we'll honor that. We just need an authoritative Svelte representative to comment here while this issue is open or file a new issue on this repo after this issue is resolved.
The text was updated successfully, but these errors were encountered: