fix(wrangler): Show feedback on Pages Function upload failure

[CarmenPopoviciu]

What this PR solves / how to test

Today, if uploading a Pages Function, or deploying a Pages project fails for whatever reason, there’s no feedback shown to the user. Worse yet, the shown message is misleading, saying the deployment was successful, when in fact it was not:

This PR ensures that moving forward, we provide users with:

• the correct feedback with respect to their Pages deployment
• the appropriate messaging depending on the status of their project's deployment status
• the appropriate logs in case of a deployment failure

Fixes #3966 and WC-2090.

Before

After

• success

• failure

• failure with log level set to debug

• unknown deployment status

Author has addressed the following

• Tests
  • TODO (before merge)
  • Included
  • Not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required / Maybe required
  • Not required because: no e2e tests changes were made
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Included
  • Not necessary because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
  • Not necessary because: bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 4cf2706

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[GregBrimble]

Thanks Carmen! Once you've got a sleep and cap added in to that loop, pretty much ready to merge, imo!

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9099454586/npm-package-wrangler-5819

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5819/npm-package-wrangler-5819

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9099454586/npm-package-wrangler-5819 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9099454586/npm-package-create-cloudflare-5819 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9099454586/npm-package-cloudflare-kv-asset-handler-5819

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9099454586/npm-package-miniflare-5819

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9099454586/npm-package-cloudflare-pages-shared-5819

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9099454586/npm-package-cloudflare-vitest-pool-workers-5819

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.56.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240512.0
workerd	1.20240512.0	1.20240512.0
workerd --version	1.20240512.0	2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[WalshyDev]

There are gonna be no logs here for DU users, they could see a green tick and red triangle but that's it. I probably wouldn't bother linking to dash

[CarmenPopoviciu]

true, but given that we couldn't tell whether the deployment was successful or failed from within wrangler, I think there might be some value in linking to Dash. I changed the wording to Check the deployment details on ...

[CarmenPopoviciu]

thanks everyone for reviewing this PR and providing valuable feedback 🙏

[wouterds]

Bless you, finally I get a clear error message what's going wrong with my deploy 😌

Edit: this PR gets an honorable mention

[CarmenPopoviciu]

whoohooo! much awesomeness! so so happy this PR helps!

[mvitorino]

Shouldn't this provide a non-zero return code so ci/cd and other scripts would fail?
I get this:

npm run deploy  && echo "Deployment was successful" || echo "Deployment failed"

> XXXX@0.1.0 deploy
> wrangler pages deploy ./build/client

▲ [WARNING] Warning: Your working directory is a git repo and has uncommitted changes

  To silence this warning, pass in --commit-dirty=true

✨ Compiled Worker successfully
🌍  Uploading... (40/40)

✨ Success! Uploaded 0 files (40 already uploaded) (0.54 sec)

✨ Uploading Functions bundle
🌎 Deploying...
✘ [ERROR] Failed to publish your Function. Got error: Your R2 bucket does not exist (workers.api.error.bucket_not_found)

❌ Deployment failed!
🪵  Logs were written to "/Users/.../Library/Preferences/.wrangler/logs/wrangler-2024-05-17_15-15-33_047.log"
Deployment was successful

[CarmenPopoviciu]

ugh...not sure how I missed that 😅. Fix PR is here: #5862

Thx so much for catching that!