fix(wrangler): wrangler pages deploy should fail if deployment failed#5862
Merged
petebacondarwin merged 1 commit intomainfrom May 20, 2024
Merged
fix(wrangler): wrangler pages deploy should fail if deployment failed#5862petebacondarwin merged 1 commit intomainfrom
wrangler pages deploy should fail if deployment failed#5862petebacondarwin merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 21b6aa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9131667461/npm-package-wrangler-5862You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5862/npm-package-wrangler-5862Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9131667461/npm-package-wrangler-5862 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9131667461/npm-package-create-cloudflare-5862 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9131667461/npm-package-cloudflare-kv-asset-handler-5862npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9131667461/npm-package-miniflare-5862npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9131667461/npm-package-cloudflare-pages-shared-5862npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9131667461/npm-package-cloudflare-vitest-pool-workers-5862Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
If a Pages project fails to deploy, `wrangler pages deploy` will log an error message, but exit successfully. It should instead throw a `FatalError`.
CarmenPopoviciu
force-pushed
the
carmen/fix-deploy
branch
from
cdf7943 to
21b6aa3
Compare
12 tasks
petebacondarwin
approved these changes
May 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
If a Pages project fails to deploy,
wrangler pages deploywill log an error message, but exit successfully. It should instead throw aFatalError.Author has addressed the following