Skip to content

[vite-plugin] Prevent Vite 8 playground teardown hangs - #15650

Merged
NuroDev merged 1 commit into
mainfrom
fix/vite-close-playground-flake
Sep 15, 2026
Merged

NuroDev merged 1 commit into
mainfrom
fix/vite-close-playground-flake

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Refs #15647.

Vite 8.1.5 can leave dependency-optimizer promises unresolved when a dev server closes, intermittently hanging the Vite plugin playground tests during teardown.

Patch the workers-sdk workspace copy with the fix from vitejs/vite#23442. The Vite 6/7 matrix jobs allow this exact Vite 8 patch to remain unused after their compatibility downgrades.

This is an internal workspace/CI workaround. It is not shipped to users or applied to their applications, which continue to select their own Vite version. The tracking issue should remain open until the upstream fix is released, the catalog is upgraded, and this patch is removed.

No changeset is required because this only changes internal tooling and CI behavior.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: existing playground coverage exercises the exact affected restart/teardown path; it passed 20 independent runs with Vitest retries disabled.

Verification:

  • CI=true pnpm install --frozen-lockfile

  • CI=true pnpm --filter @vite-plugin-cloudflare/playground exec vitest run -c vitest.config.e2e.ts react-spa/__tests__/experimental-headers-and-redirects/react-spa.spec.ts --retry=0

  • pnpm exec oxfmt --check .github/workflows/vite-plugin-playgrounds.yml pnpm-workspace.yaml

  • Public documentation

    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is an internal CI-only workaround with no user-facing behavior change.

Devin Review

@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ca33eff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin petebacondarwin added ci-flake Applied to PRs addressing CI flakiness ci:no-changeset-required Skip pull request checks for a valid changeset ci:no-tests Skip pull request checks for tests package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Sep 15, 2026
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Sep 15, 2026
@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team September 15, 2026 11:58
@workers-devprod

workers-devprod commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15650

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15650

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15650

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15650

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15650

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15650

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15650

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15650

miniflare

npm i https://pkg.pr.new/miniflare@15650

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15650

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15650

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15650

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15650

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15650

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15650

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15650

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15650

wrangler

npm i https://pkg.pr.new/wrangler@15650

commit: ca33eff

@ask-bonk

ask-bonk Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@NuroDev
NuroDev enabled auto-merge (squash) September 15, 2026 13:09

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@NuroDev
NuroDev merged commit 40dd545 into main Sep 15, 2026
80 of 95 checks passed
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Sep 15, 2026
@NuroDev
NuroDev deleted the fix/vite-close-playground-flake branch September 15, 2026 13:10
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset ci:no-tests Skip pull request checks for tests ci-flake Applied to PRs addressing CI flakiness package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants