Repository navigation
[vite-plugin] Prevent Vite 8 playground teardown hangs - #15650
Merged
Merged
Conversation
|
workers-devprod
requested review from
a team and
dario-piotrowicz
and removed request for
a team
September 15, 2026 11:58
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
LGTM |
NuroDev
approved these changes
Sep 15, 2026
NuroDev
enabled auto-merge (squash)
September 15, 2026 13:09
workers-devprod
approved these changes
Sep 15, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
4 tasks
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #15647.
Vite 8.1.5 can leave dependency-optimizer promises unresolved when a dev server closes, intermittently hanging the Vite plugin playground tests during teardown.
Patch the workers-sdk workspace copy with the fix from vitejs/vite#23442. The Vite 6/7 matrix jobs allow this exact Vite 8 patch to remain unused after their compatibility downgrades.
This is an internal workspace/CI workaround. It is not shipped to users or applied to their applications, which continue to select their own Vite version. The tracking issue should remain open until the upstream fix is released, the catalog is upgraded, and this patch is removed.
No changeset is required because this only changes internal tooling and CI behavior.
Verification:
CI=true pnpm install --frozen-lockfileCI=true pnpm --filter @vite-plugin-cloudflare/playground exec vitest run -c vitest.config.e2e.ts react-spa/__tests__/experimental-headers-and-redirects/react-spa.spec.ts --retry=0pnpm exec oxfmt --check .github/workflows/vite-plugin-playgrounds.yml pnpm-workspace.yamlPublic documentation