Repository navigation
fix(optimizer): settle pending dependency processing on close - #23442
Closed
leonardoventurini wants to merge 2 commits into
Closed
leonardoventurini wants to merge 2 commits into
leonardoventurini wants to merge 2 commits into
Conversation
leonardoventurini
marked this pull request as ready for review
September 6, 2026 18:27
Member
|
Sorry I noticed this PR after I made the fix (#23567) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22934.
Settle current and queued dependency-processing promises on shutdown so pending loads cannot block
server.close(). Adds deterministic regressions for shutdown before initialization and during optimization.Builds on top of #22935.