Skip to content

[vite-plugin] Prevent Vite 8 playground teardown hangs #15650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NuroDev merged 1 commit into from
Sep 15, 2026
Merged

[vite-plugin] Prevent Vite 8 playground teardown hangs #15650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/vite-plugin-playgrounds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,16 @@ jobs:
}
console.log(`VITE_PLUGIN_BUILD_HASH=${task.hash}`);
' >> "$GITHUB_ENV"
# The exact Vite 8 workspace patch is intentionally unused after these
# compatibility-job downgrades.
- name: Downgrade to Vite 6
if: steps.changes.outputs.everything_but_markdown == 'true' && matrix.vite == 'vite-6'
run: |
pnpm update -r --no-save vite@^6.1.0
pnpm --config.allow-unused-patches=true update -r --no-save vite@^6.1.0
- name: Downgrade to Vite 7
if: steps.changes.outputs.everything_but_markdown == 'true' && matrix.vite == 'vite-7'
run: |
pnpm update -r --no-save vite@^7.0.0
pnpm --config.allow-unused-patches=true update -r --no-save vite@^7.0.0
- name: Run dev playground tests
if: steps.changes.outputs.everything_but_markdown == 'true'
# We use `--only` to prevent TurboRepo from rebuilding dependencies
Expand Down
15 changes: 15 additions & 0 deletions patches/vite@8.1.5.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
diff --git a/dist/node/chunks/node.js b/dist/node/chunks/node.js
index 46a39acd56595208450431ca141ea9db4804d154..ada5cb54ab8f99c19ad482320ee9e8aac6c8f5e6 100644
--- a/dist/node/chunks/node.js
+++ b/dist/node/chunks/node.js
@@ -33662,6 +33662,10 @@ function createDepsOptimizer(environment) {
let discover;
async function close() {
closed = true;
+ // Pending loads must be released even if their batch never finishes or
+ // the optimizer has not been initialized yet.
+ depOptimizationProcessing.resolve();
+ resolveEnqueuedProcessingPromises();
await Promise.allSettled([
discover?.cancel(),
depsOptimizer.scanProcessing,
Loading
Loading