Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex config util #2199

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

sconwayaus
Copy link
Contributor

To support #2074 raised by @IEncinas10 (Adding regex to name styling rules), this PR adds a function to return a ConfigValueSetter for a regex. The function checks the validity of the regex before returning with a status response.

@hzeller
Copy link
Collaborator

hzeller commented Jun 13, 2024

Can you check the output of the clang-tidy ?

Unfortunately, the github UI for some reason does not allow to unfold parts of the logs, so we need to look at the raw-log:

https://pipelinesghubeus23.actions.githubusercontent.com/Vjp6wX1uV2r1O1Bj6h2lKqrBcOftZCnAHGZLuirThVBBZtBnxy/_apis/pipelines/1/runs/5667/signedlogcontent/2?urlExpires=2024-06-13T15%3A14%3A55.5066083Z&urlSigningMethod=HMACV1&urlSignature=YElrIfSHMhUjzc2eoSGHbSqqh7ZGMx3U36SdQU3XmhY%3D

Looks like it found an opportunity to make a

 if (foo) {
    return bar;
} else {
   return baz;
}

to

if (foo) {
   return bar;
}
reteurn baz;

(also some missing or superfluous includes)

Copy link
Collaborator

@hzeller hzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Ready to merge after clang-tidy is happy.

@sconwayaus
Copy link
Contributor Author

Should be good now. Thanks

@hzeller hzeller merged commit 3c6eb50 into chipsalliance:master Jun 14, 2024
31 of 34 checks passed
@sconwayaus sconwayaus deleted the regex_config_util branch June 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants