Repository navigation
chore(release): Phase 0 build pre-flight — the checks that only explode on the tag, before the freeze - #17276
Merged
diegosouzapw merged 3 commits intoOct 20, 2026
Conversation
…de on the tag, before the freeze v3.8.52 shipped with three defects the PR CI never exercises: the electron/ lockfile out of sync (electron-release.yml installs with npm ci, the CI smoke with npm install — #15157 on v3.8.51, #17212 on v3.8.52), the Bun runner-web image's dead apt packages (best-effort stage, surfaced only through the manifest guard — #17223/#17236) and README version claims the cycle bump skipped (#17237). scripts/release/preflight-build.sh runs them in one go with a result table and per-check logs: version claims, root + electron `npm ci --dry-run`, vitest, build:cli + pack-boot (the packaging path npm-publish runs) and the new preflight-bun-apt-smoke.sh, which builds the runner-web apt block alone on the Bun base image (default on the .113 over ssh). --quick keeps the 20-second subset for a mid-cycle check. On release/v3.8.53 today: --quick passes; the apt smoke reproduces the four E: lines until #17236 lands.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
"Run the build tests before generating" was only partially true for v3.8.52: the static gates were RELEASE-GREEN and
main's CI matrix was green, yet three defects surfaced only on the tag, because no PR check exercises them:electron/package-lock.jsonout of sync (npm ciEUSAGE)electron-release.ymlinstalls withnpm ci; the CI Electron smoke usesnpm install, which repairs the lock silentlyrunner-webapt list with dead packagescontinue-on-error; it only surfaced through the stale-digest guard of the manifest jobrelease/v3.8.53born red — #17237What this PR does
scripts/release/preflight-build.sh— one run, one table, one log per check (_artifacts/preflight/):bump-version-claims.mjs --check), root andelectron/npm ci --dry-run --ignore-scripts— the--quicksubset, ~20 s;npm run test:vitest,npm run build:cli,npm run check:pack-boot(the packaging pathnpm-publish.ymlruns) — skippable with--no-buildwhen the CI artifact of the frozen tip is already proven;scripts/release/preflight-bun-apt-smoke.sh— extracts therunner-webRUN apt-get …block fromDockerfile.bunverbatim, builds it alone on the Bun base image (default over ssh on the .113,PREFLIGHT_DOCKER_HOST=""for local Docker) and asks Chromium for its version — 2 minutes instead of the 12 GB stage.--no-dockerskips it./generate-releaseskill (Phase 0,.agentsrepo) now calls the script before the freeze; the unit shards stay the release PR's CI evidence (8 × 40 min does not fit a local pre-flight).Validation
scripts/release/preflight-build.sh --quickonrelease/v3.8.53(dba56ba9)scripts/release/preflight-bun-apt-smoke.shon the currentDockerfile.bunE:lines of the release run (gconf-service,stdc++6,fonts-kacst) — passes with #17236's list (proven on the .113 before that PR)bash -nboth scriptsrelease/v3.8.53— unrelated to this change.