Repository navigation
fix(electron): resync electron/package-lock.json with its package.json (v3.8.52 desktop builds) - #17212
Merged
Conversation
Post-release fix for v3.8.52 (lands on main first, per the post-merge rule). The lockfile at the v3.8.52 tag lacks the electron-builder-squirrel-windows, electron-winstaller, @electron/windows-sign and postject subtrees (the same entries #15157 restored after v3.8.51; the sync-back took the release-side copy again), so npm ci in electron/ fails the Windows and Linux desktop builds of the tag (run 39315974450, jobs 118285308012 / 118285308204). Regenerated with npm install --package-lock-only from the unchanged electron/package.json: 195 lines added, 0 removed, no existing version changed; npm ci --dry-run passes on npm 12.0.2.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
diegosouzapw
added a commit
that referenced
this pull request
Oct 20, 2026
…de on the tag, before the freeze (#17276) * chore(release): Phase 0 build pre-flight — the checks that only explode on the tag, before the freeze v3.8.52 shipped with three defects the PR CI never exercises: the electron/ lockfile out of sync (electron-release.yml installs with npm ci, the CI smoke with npm install — #15157 on v3.8.51, #17212 on v3.8.52), the Bun runner-web image's dead apt packages (best-effort stage, surfaced only through the manifest guard — #17223/#17236) and README version claims the cycle bump skipped (#17237). scripts/release/preflight-build.sh runs them in one go with a result table and per-check logs: version claims, root + electron `npm ci --dry-run`, vitest, build:cli + pack-boot (the packaging path npm-publish runs) and the new preflight-bun-apt-smoke.sh, which builds the runner-web apt block alone on the Bun base image (default on the .113 over ssh). --quick keeps the 20-second subset for a mid-cycle check. On release/v3.8.53 today: --quick passes; the apt smoke reproduces the four E: lines until #17236 lands. * docs(changelog): fragment for the Phase 0 build pre-flight (#17276)
arashashrafii
pushed a commit
to arashashrafii/OmniRoute
that referenced
this pull request
Oct 24, 2026
cheaper-inference#17212) Post-release fix for v3.8.52 (lands on main first, per the post-merge rule). The lockfile at the v3.8.52 tag lacks the electron-builder-squirrel-windows, electron-winstaller, @electron/windows-sign and postject subtrees (the same entries cheaper-inference#15157 restored after v3.8.51; the sync-back took the release-side copy again), so npm ci in electron/ fails the Windows and Linux desktop builds of the tag (run 39315974450, jobs 118285308012 / 118285308204). Regenerated with npm install --package-lock-only from the unchanged electron/package.json: 195 lines added, 0 removed, no existing version changed; npm ci --dry-run passes on npm 12.0.2. (cherry picked from commit fa6e0f1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-release fix for v3.8.52 — lands on
mainfirst (post-merge read-only rule), then reachesrelease/v3.8.53through the Phase 5 sync-back.What broke
electron-release.ymlfor tagv3.8.52failed on Windows and Linux at Install Electron dependencies (run 39315974450, jobs 118285308012 / 118285308204):Reproduced locally at
ad6f33f6withnpm ci --dry-run --ignore-scriptsinelectron/(exit 1, same list).Why
Same class as #15157 after v3.8.51: the lockfile copy that reached the tag lacks the Windows-target subtree of
electron-builder@26.15.3.electron/package.jsononly changedelectron ^44.4.3 → ^44.7.0in the cycle (#15577, #16561). The CI Electron smoke job installs withnpm install(notnpm ci), which silently repairs the lock on the runner — so main's CI stays green while the release build fails.Fix
npm install --package-lock-only --ignore-scriptsfrom the unchangedelectron/package.json:electron/package-lock.json: 195 lines added, 0 removed, no existing version changed — 13 newnode_modules/*entries:electron-builder-squirrel-windows,electron-winstaller(+ itsfs-extra/jsonfile/universalify),@electron/windows-sign(+fs-extra),cross-dirname,temp,mkdirp,rimraf,postject(+commander).npm ci --dry-run --ignore-scriptsnow passes (287 packages, npm 12.0.2).changelog.d/fixes/(folded into[3.8.53]by the next reconciliation).After merge
gh workflow run electron-release.yml --ref main -f version=v3.8.52 -f publish_npm=false— rebuilds the desktop assets from the repaired line and attaches them to the existing v3.8.52 release (v3.8.50 / v3.8.51 precedent).Validation
npm ci --dry-run --ignore-scriptsinelectron/atad6f33f6electron/package-lock.json+changelog.d/fixes/<PR>-electron-lockfile-resync.mdmain's tip CI — unrelated to this change).