Repository navigation
fix(electron): resync electron/package-lock.json with its package.json - #15157
Merged
Merged
Conversation
The v3.8.51 release squash replaced main's electron lockfile (resynced in #11982) with the release branch's copy, which lacks electron-builder-squirrel-windows, electron-winstaller and @electron/windows-sign. The desktop build's 'npm ci' in electron/ rejected it, failing the Windows and Linux Electron legs. Regenerated from electron/package.json with --package-lock-only: additions only, no version changes; 'npm ci --dry-run' passes on npm 10.9.8 and 11.15.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
arashashrafii
pushed a commit
to arashashrafii/OmniRoute
that referenced
this pull request
Oct 11, 2026
cheaper-inference#15157) Post-release v3.8.51 fix on main: electron lockfile resynced with its package.json (additions only; npm ci --dry-run passes on npm 10.9.8 and 11.15.0). Restores the Windows/Linux desktop builds. (cherry picked from commit 21f1573)
diegosouzapw
added a commit
that referenced
this pull request
Oct 19, 2026
#17212) Post-release fix for v3.8.52 (lands on main first, per the post-merge rule). The lockfile at the v3.8.52 tag lacks the electron-builder-squirrel-windows, electron-winstaller, @electron/windows-sign and postject subtrees (the same entries #15157 restored after v3.8.51; the sync-back took the release-side copy again), so npm ci in electron/ fails the Windows and Linux desktop builds of the tag (run 39315974450, jobs 118285308012 / 118285308204). Regenerated with npm install --package-lock-only from the unchanged electron/package.json: 195 lines added, 0 removed, no existing version changed; npm ci --dry-run passes on npm 12.0.2.
diegosouzapw
added a commit
that referenced
this pull request
Oct 20, 2026
…de on the tag, before the freeze (#17276) * chore(release): Phase 0 build pre-flight — the checks that only explode on the tag, before the freeze v3.8.52 shipped with three defects the PR CI never exercises: the electron/ lockfile out of sync (electron-release.yml installs with npm ci, the CI smoke with npm install — #15157 on v3.8.51, #17212 on v3.8.52), the Bun runner-web image's dead apt packages (best-effort stage, surfaced only through the manifest guard — #17223/#17236) and README version claims the cycle bump skipped (#17237). scripts/release/preflight-build.sh runs them in one go with a result table and per-check logs: version claims, root + electron `npm ci --dry-run`, vitest, build:cli + pack-boot (the packaging path npm-publish runs) and the new preflight-bun-apt-smoke.sh, which builds the runner-web apt block alone on the Bun base image (default on the .113 over ssh). --quick keeps the 20-second subset for a mid-cycle check. On release/v3.8.53 today: --quick passes; the apt smoke reproduces the four E: lines until #17236 lands. * docs(changelog): fragment for the Phase 0 build pre-flight (#17276)
arashashrafii
pushed a commit
to arashashrafii/OmniRoute
that referenced
this pull request
Oct 24, 2026
cheaper-inference#17212) Post-release fix for v3.8.52 (lands on main first, per the post-merge rule). The lockfile at the v3.8.52 tag lacks the electron-builder-squirrel-windows, electron-winstaller, @electron/windows-sign and postject subtrees (the same entries cheaper-inference#15157 restored after v3.8.51; the sync-back took the release-side copy again), so npm ci in electron/ fails the Windows and Linux desktop builds of the tag (run 39315974450, jobs 118285308012 / 118285308204). Regenerated with npm install --package-lock-only from the unchanged electron/package.json: 195 lines added, 0 removed, no existing version changed; npm ci --dry-run passes on npm 12.0.2. (cherry picked from commit fa6e0f1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-release fix for v3.8.51 (lands on main first, per the post-merge rule). The release squash replaced main's electron lockfile (resynced in #11982) with the release branch copy, which lacks electron-builder-squirrel-windows, electron-winstaller and @electron/windows-sign, so
npm ciinelectron/failed the Windows and Linux desktop builds of the v3.8.51 tag (run 36656316532). Regenerated with--package-lock-onlyfrom the unchanged electron/package.json: 195 lines added, 0 removed, no version changes;npm ci --dry-runpasses on npm 10.9.8 and 11.15.0.