Repository navigation
feat(i18n): forward the optional reasoning control in the translation backend - #15462
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Conversation
… backend Each new case fails without the change.
maxmad64bis
force-pushed
the
feat/translation-reasoning-effort
branch
from
October 3, 2026 15:38
e7aeddc to
58a711c
Compare
maxmad64bis
marked this pull request as ready for review
October 3, 2026 16:26
This was referenced Oct 4, 2026
Closed
diegosouzapw
merged commit Oct 6, 2026
8349538
into
cheaper-inference:release/v3.8.52
156 of 224 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The translation request carries no reasoning control, so models that reason spend most of the run thinking through a short translation task instead of emitting the translation. The request builder has no field for that control, which keeps the long thinking path on for those requests. The change adds an optional setting that stays off when unset and forwards the trimmed value to the request body only when the operator sets it.
Related Issues
Validation
npm run lintTests Added Or Updated
tests/unit/i18n-translate-backend.test.ts: covers unset, empty and blank values (field stays absent), the trimmed forwarded value, the exact request body without the field, and the retry path keeping the field.Coverage Notes
N/A — no touched file lives under
src/,open-sse/,electron/orbin/.Reviewer Notes