Repository navigation
feat(proxy-subscription): verify the generated core configuration before replacing the file - #15142
Closed
maxmad64bis wants to merge 2 commits into
Closed
maxmad64bis wants to merge 2 commits into
maxmad64bis wants to merge 2 commits into
Conversation
maxmad64bis
force-pushed
the
feat/core-config-verify
branch
from
September 29, 2026 20:32
36f4041 to
dacc2b1
Compare
5 tasks done
maxmad64bis
force-pushed
the
feat/core-config-verify
branch
2 times, most recently
from
September 30, 2026 00:08
e5f05d7 to
d2aa381
Compare
maxmad64bis
marked this pull request as ready for review
September 30, 2026 00:08
This was referenced Sep 30, 2026
maxmad64bis
marked this pull request as draft
October 1, 2026 22:35
maxmad64bis
force-pushed
the
feat/core-config-verify
branch
from
October 2, 2026 00:08
d2aa381 to
03ddc5a
Compare
maxmad64bis
marked this pull request as ready for review
October 2, 2026 08:59
4 of 5 tasks
maxmad64bis
force-pushed
the
feat/core-config-verify
branch
from
October 2, 2026 15:07
559a830 to
e680e64
Compare
5 tasks
maxmad64bis
force-pushed
the
feat/core-config-verify
branch
2 times, most recently
from
October 2, 2026 16:37
8c146c3 to
02062c6
Compare
This was referenced Oct 2, 2026
…ore replacing the file Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
maxmad64bis
force-pushed
the
feat/core-config-verify
branch
from
October 4, 2026 13:27
02062c6 to
e159038
Compare
Contributor
Author
|
Closing as already covered by #15564, now on The stack (#15141, #15142, #15238, #15295) was squashed there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An unchecked replacement can ship a broken core file. The core now checks the generated file with its own binary first: a pass swaps it in atomically, a miss leaves the adopted file alone and raises a warning instead.
Related Issues
Validation
npm run lint— ESLint on the touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.52 #15306)Tests Added Or Updated
/tmp/attacker/sing-boxas refusedcoreBinaryPath) are intentional refusal proofs, not real paths.Coverage Notes
Reviewer Notes
AGENTS.md,README.md,llm.txtanddocs/i18n/*/llm.txt(counters + mirrors) with feat(proxy-subscription): generate the local proxy-core configuration (opt-in) #15141, feat(proxy-subscription): reload the proxy core after a verified config replacement #15238 and feat(proxy-subscription): prune nodes the core check rejects, then retry verification #15295: one stack, parent-first merge, no parallel lines. Overlaps: either order with fix(proxy-subscription): report internal core config failure distinctly #15377, fix(proxy-health): skip sweep probes already proven by recent production successes #14805, feat(proxies): accept operator-provided dated egress observations for pool members #15314, feat(i18n): forward the optional reasoning control in the translation backend #15462, feat(proxy-subscription): reload the proxy core after a verified config replacement #15238 and feat(proxy-subscription): prune nodes the core check rejects, then retry verification #15295, with a rebase on conflict.