Repository navigation
feat(i18n): translate several locales per request in sync-ui-keys - #15562
Merged
diegosouzapw merged 2 commits intoOct 6, 2026
Conversation
This was referenced Oct 5, 2026
maxmad64bis
marked this pull request as ready for review
October 5, 2026 14:06
diegosouzapw
merged commit Oct 6, 2026
994324f
into
cheaper-inference:release/v3.8.52
7 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Translating new interface keys sends one request per language today, so 66 languages mean at least 66 requests while the concurrency setting only overlaps work inside each language. The per-request grouping already covered keys, never languages. This change adds an opt-in grouping of languages: without the flag every request stays exactly as before, and with it one request carries several languages and each broken line fails only its own language.
Related Issues
Validation
npm run lintTests Added Or Updated
tests/unit/i18n-translate-backend.test.ts— multi-language response parsing by language code, single-request batching, broken-line isolation, and quote restoration.tests/unit/i18n-sync-ui-keys-locales-per-request.test.ts— flag parsing and defaults, locale chunking, placeholder union with divergent-source guard, planned-group requests with per-language retry, dry-run silence, and identical repeat runs.Coverage Notes
N/A — no touched directory from the template list.
Reviewer Notes
--locales-per-request=11six requests cover 66 languages, with live timing still to be recorded on a backend run.