Repository navigation
feat(proxy-subscription): prune nodes the core check rejects, then retry verification - #15295
Closed
maxmad64bis wants to merge 4 commits into
Closed
maxmad64bis wants to merge 4 commits into
maxmad64bis wants to merge 4 commits into
Conversation
maxmad64bis
force-pushed
the
feat/core-prune-rejected-node
branch
4 times, most recently
from
October 1, 2026 19:19
00dd622 to
509b1f0
Compare
maxmad64bis
marked this pull request as ready for review
October 1, 2026 20:06
maxmad64bis
force-pushed
the
feat/core-prune-rejected-node
branch
from
October 1, 2026 21:09
509b1f0 to
4f2ee77
Compare
maxmad64bis
marked this pull request as draft
October 1, 2026 22:35
maxmad64bis
force-pushed
the
feat/core-prune-rejected-node
branch
from
October 2, 2026 01:05
4f2ee77 to
a1a5e0b
Compare
4 of 5 tasks
maxmad64bis
marked this pull request as ready for review
October 2, 2026 09:18
maxmad64bis
force-pushed
the
feat/core-prune-rejected-node
branch
from
October 2, 2026 15:08
a1a5e0b to
12bddae
Compare
This was referenced Oct 2, 2026
Closed
maxmad64bis
force-pushed
the
feat/core-prune-rejected-node
branch
2 times, most recently
from
October 2, 2026 16:46
96214a8 to
ceaf09a
Compare
This was referenced Oct 2, 2026
…ore replacing the file Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
maxmad64bis
force-pushed
the
feat/core-prune-rejected-node
branch
from
October 4, 2026 15:10
ceaf09a to
77005ab
Compare
5 tasks
Collaborator
|
Closing as already covered by #15564, now on
Thanks @maxmad64bis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A single node rejected by core verification used to block the whole refresh, leaving the subscription stale until the source changed. The verifier discarded the entire candidate on one failure with no way to say which node caused it. Now the check can name the offending node, which is pruned (recorded as skipped) and verification retried, up to 8 times, so the remaining nodes still apply with a warning.
Related Issues
Validation
npm run lint— No new ESLint warnings is greenTests Added Or Updated
proxySubscription.corePruneRejectedsuite (10 cases, injected check runner): 1 rejected of 3, 2 rejected over 2 rounds, bound reached, error with no named node, unowned position, all-pruned stops before empty, attempt budget, resolver registry, adapter mapping incl. first-match and out-of-range (all 10 fail without the change, pass with it).coreConfigSync+coreApply: 31/31 green; touched-file suites 4/4 green; full unit run 15/15 green.Coverage Notes
src/lib/proxySubscription/coreConfig/sync.ts: prune loop, warning helper, round runner, and model filter — covered by the 10 new cases (single prune, double prune, bound, unnamed error, unowned position, all-pruned stop, budget).src/lib/proxySubscription/coreConfig/apply.ts: offending propagation through the existing outcome return — covered by the same 10 cases via the injected check runner (all 10 fail without the change, pass with it).src/lib/proxySubscription/coreConfig/renderers.ts+singbox.ts: resolver registry and adapter mapping (first-match, out-of-range, unowned) — covered by the registry and adapter cases.Reviewer Notes
openapi.generated.ts,subscriptionService.ts, same failure on feat(proxy-subscription): verify the generated core configuration before replacing the file #15142) and mutation-test-coverage (third-party modules missing fromstryker.conf). Thedocs-alldelta is only the new migration counter, left to the maintainer. Either order with fix(proxy-subscription): report internal core config failure distinctly #15377, with a rebase on conflict.