Skip to content

Update the release-next branch with latest content from master#731

Merged
jetstack-bot merged 10 commits intorelease-nextfrom
master
Oct 27, 2021
Merged

Update the release-next branch with latest content from master#731
jetstack-bot merged 10 commits intorelease-nextfrom
master

Conversation

@wallrj
Copy link
Member

@wallrj wallrj commented Oct 27, 2021

In preparation for the release-1.6

Miguel Frias Mosquea and others added 10 commits October 16, 2021 18:11
Update helm.md
0f83082 
Timeout seconds expects an integer, not a string, not "4s" but just a 4.
@JoshVanL
Change links in usage certificate to kubectl plugin #renew to be
38aa876 
relative

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot
Merge pull request #719 from JoshVanL/release-1.5-usage-kubectl-plugi…
44623e5 
…n-renew-reletive-path

Change links in usage certificate to kubectl plugin #renew to be relative
@jetstack-bot
Merge pull request #716 from maikeldotuk/patch-1
2065940 
Update helm.md
@SgtCoDFish
updates arising from the signing release process
8798fe5 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot
Merge pull request #714 from SgtCoDFish/relnoteupdate
328bc58 
Updates arising from the signing release process
@JoshVanL
Replace some absolute path with relative paths to not cause issues with
37cfa15 
versioned pages

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot
Merge pull request #726 from JoshVanL/dont-use-absolute-paths
51e977f 
Replace some absolute paths with relative paths to not cause issues with versioned builds
@SgtCoDFish
update release notes to account for quay.io
e084967 
also update version for installing cmrel

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot
Merge pull request #725 from SgtCoDFish/relnosign
d5d127b 
Update release notes to account for quay.io
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 27, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 27, 2021

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@netlify
Copy link

netlify bot commented Oct 27, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: d5d127b

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/617957df8eb58d0008b29bdf

😎 Browse the preview: https://deploy-preview-731--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2021
@wallrj wallrj added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 27, 2021
@jetstack-bot jetstack-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 27, 2021
@wallrj wallrj removed the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Oct 27, 2021
@wallrj
Copy link
Member Author

wallrj commented Oct 27, 2021

/override dco

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 27, 2021

@wallrj: Overrode contexts on behalf of wallrj: dco

Details

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jakexks
jakexks approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@jetstack-bot jetstack-bot merged commit 5fcfa7e into release-next Oct 27, 2021
@jetstack-bot jetstack-bot mentioned this pull request Oct 27, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wallrj @jetstack-bot @jakexks @JoshVanL @SgtCoDFish