Skip to content

Update helm.md#716

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
maikelthedev:patch-1
Oct 19, 2021
Merged

Update helm.md#716
jetstack-bot merged 1 commit intocert-manager:masterfrom
maikelthedev:patch-1

Conversation

@maikelthedev
Copy link
Copy Markdown
Contributor

Timeout seconds expects an integer, not a string, not "4s" but just a 4.

Timeout seconds expects an integer, not a string, not "4s" but just a 4.
@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Oct 16, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 16, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 0f83082

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/616af9da53d3f90007cf1a6d

😎 Browse the preview: https://deploy-preview-716--cert-manager-website.netlify.app/docs/installation/helm

@jetstack-bot
Copy link
Copy Markdown
Contributor

Hi @maikeldotuk. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2021
@maikelthedev
Copy link
Copy Markdown
Contributor Author

/assign @maelvls

Copy link
Copy Markdown
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, maikeldotuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@jakexks
Copy link
Copy Markdown
Member

jakexks commented Oct 19, 2021

/override dco

@jetstack-bot
Copy link
Copy Markdown
Contributor

@jakexks: Overrode contexts on behalf of jakexks: dco

Details

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakexks jakexks added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 19, 2021
@jetstack-bot jetstack-bot merged commit 2065940 into cert-manager:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants