Skip to content

Updates arising from the signing release process#714

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:relnoteupdate
Oct 21, 2021
Merged

Updates arising from the signing release process#714
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:relnoteupdate

Conversation

@SgtCoDFish
Copy link
Member

@SgtCoDFish SgtCoDFish commented Oct 14, 2021

I wouldn't normally leave commented-out text in a PR but I think this is a good case for it 😁

No major changes here, really.

/kind documentation

@jetstack-bot jetstack-bot added kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 14, 2021
@netlify
Copy link

netlify bot commented Oct 14, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 8798fe5

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61715c1661e1d50007c996bb

😎 Browse the preview: https://deploy-preview-714--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2021
munnerz
munnerz reviewed Oct 21, 2021
View reviewed changes
wallrj
wallrj requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a couple of typos.

And the Warning message in that document refers to the public keys "above" but they're "below":
image

https://deploy-preview-714--cert-manager-website.netlify.app/docs/installation/code-signing/#helm-charts

@SgtCoDFish
updates arising from the signing release process
8798fe5 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
wallrj
wallrj approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 328bc58 into cert-manager:master Oct 21, 2021
@SgtCoDFish SgtCoDFish deleted the relnoteupdate branch October 21, 2021 14:16
This was referenced Oct 27, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@munnerz munnerz munnerz left review comments

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SgtCoDFish @jetstack-bot @munnerz @wallrj