Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 46972c9 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/617974706c5af20008d1c3b4 😎 Browse the preview: https://deploy-preview-728--cert-manager-website.netlify.app/docs/installation/cmctl |
Not sure if I missed any discussion in the large slack thread from yesterday, does this need still fixing in the release-1.5 branch? /retest |
maelvls
left a comment
There was a problem hiding this comment.
Hi. I left a couple of suggestions that aren't blocking.
1d38eb8 to
744e487
Compare
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
|
/retest |
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
|
/lgtm |
From #715
This PR adds a page for the new cmctl CLI. This page mostly replaces the existing kubectl-plugin page taking the same content but changing the commands and some wording.
The exiting kubectl-plugin page has been stripped down to just installing and linking to cmctl.
Users can still find all the docs they need, but moving the docs this way helps nudge users into using cmctl which has a better UX.
/assign @jakexks