Skip to content

cmctl release notes docs#735

Merged
jetstack-bot merged 9 commits intocert-manager:release-nextfrom
wallrj:cmctl-release-notes-docs
Oct 27, 2021
Merged

cmctl release notes docs#735
jetstack-bot merged 9 commits intocert-manager:release-nextfrom
wallrj:cmctl-release-notes-docs

Conversation

@wallrj
Copy link
Member

@wallrj wallrj commented Oct 27, 2021

Add a link to the cmctl docs to the release-notes

Also resolve a conflict in the .spelling file.

JoshVanL and others added 6 commits October 27, 2021 16:16
@JoshVanL
Adds documentation for the new cmctl command.
99275e8 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Change faq reference to kubectl-plugin to cmctl
912e84d 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Adds redirects for 'kubectl cert-manager' headings to 'cmctl'
eb86fbe 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Adds style and grammar suggestions
744e487 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Fix spelling
46972c9 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot
Merge pull request cert-manager#728 from JoshVanL/cmctl-master
4116225 
cmctl
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 27, 2021
@netlify
Copy link

netlify bot commented Oct 27, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 38e61e3

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61797e06140783000791b786

😎 Browse the preview: https://deploy-preview-735--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 27, 2021
wallrj added 2 commits October 27, 2021 17:23
@wallrj
Merge remote-tracking branch 'origin/master' into cmctl-release-notes…
45a5366 
…-docs

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Add link in the release-notes to cmctl docs
5019c9f 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj force-pushed the cmctl-release-notes-docs branch from afcaa22 to 5019c9f Compare October 27, 2021 16:25
@wallrj
Sort and deduplicate the spelling file
38e61e3 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 27, 2021

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wallrj
Copy link
Member Author

wallrj commented Oct 27, 2021

/override dco

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 27, 2021

@wallrj: Overrode contexts on behalf of wallrj: dco

Details

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager label Oct 27, 2021
@jetstack-bot jetstack-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 27, 2021
@wallrj wallrj added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 27, 2021
@wallrj wallrj changed the title WIP: Cmctl release notes docs cmctl release notes docs Oct 27, 2021
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2021
@JoshVanL
Copy link
Contributor

JoshVanL commented Oct 27, 2021

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@jetstack-bot jetstack-bot merged commit 232a31c into cert-manager:release-next Oct 27, 2021
@jetstack-bot jetstack-bot mentioned this pull request Oct 27, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
@wallrj wallrj deleted the cmctl-release-notes-docs branch February 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JoshVanL JoshVanL

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wallrj @jetstack-bot @JoshVanL