Add a 1.6 release notes document#730
Merged
jetstack-bot merged 4 commits intocert-manager:release-nextfrom Oct 27, 2021
Merged
Conversation
jetstack-bot
added
do-not-merge/work-in-progress
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 323cf86 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/617979b0c136ff0007faa7b8 😎 Browse the preview: https://deploy-preview-730--cert-manager-website.netlify.app/docs/release-notes/release-notes-1.6 |
jetstack-bot
added
the
size/M
wallrj
removed
the
do-not-merge/cherry-pick-not-approved
jetstack-bot
added
the
do-not-merge/cherry-pick-not-approved
wallrj
added
the
cherry-pick-approved
jetstack-bot
removed
the
do-not-merge/cherry-pick-not-approved
erikgb
reviewed
Oct 27, 2021
Member
|
Ah, I had a WIP branch for this too: master...jakexks:release-notes-v1.6 We should merge these together 😄 |
jetstack-bot
added
dco-signoff: no
wallrj
force-pushed
the
release-notes-1.6
branch
from
53a485c to
d26dd57
Compare
jetstack-bot
added
dco-signoff: yes
wallrj
force-pushed
the
release-notes-1.6
branch
from
d26dd57 to
e038c5e
Compare
wallrj
changed the title
jetstack-bot
removed
the
do-not-merge/work-in-progress
* Release notes for version 1.6 * A note about the JKS minimum password length breaking change Co-authored-by: Jake Sanders <i@am.so-aweso.me> Signed-off-by: Richard Wall <richard.wall@jetstack.io>
wallrj
force-pushed
the
release-notes-1.6
branch
from
e038c5e to
adbc821
Compare
erikgb
approved these changes
Oct 27, 2021
Member
erikgb
left a comment
erikgb
left a comment
There was a problem hiding this comment.
LGTM, at least the wording for the issue with short password for JKS keystores.
jakexks
approved these changes
Oct 27, 2021
Member
jakexks
left a comment
jakexks
left a comment
There was a problem hiding this comment.
Soft approval on wording.
A link to the cmctl docs (pending merge) needs to be added
jetstack-bot
added
the
approved
And sort the word list Signed-off-by: Richard Wall <richard.wall@jetstack.io>
jetstack-bot
added
size/L
maelvls
reviewed
Oct 27, 2021
jetstack-bot
added
dco-signoff: no
Co-authored-by: Maël Valais <mael@vls.dev> Signed-off-by: Richard Wall <richard.wall@jetstack.io>
wallrj
force-pushed
the
release-notes-1.6
branch
from
ded320a to
0151ff9
Compare
jetstack-bot
added
dco-signoff: yes
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb, jakexks, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wallrj
commented
Oct 27, 2021
| @@ -1,307 +1,321 @@ | |||
| (sub)domains | |||
Member
Author
There was a problem hiding this comment.
I sorted these words to make it easier to find existing variations on words which triggered the spell check errors.
| as an unintended side effect of [upgrading keystore-go from `v2` to `v4`][jks-keystore-upgrade-pr]. | ||
| If you are using a shorter password, certificates will fail to renew, | ||
| and the only observable error will be in the cert-manager logs. | ||
| We are discussing the best remediation for a future `v1.6.1` release. |
Member
Author
There was a problem hiding this comment.
I copied @jakexks 's words from the cert-manager/cert-manager release page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes for cert-manager 1.6