Follow-up to #570: Add a section about Certificate's renewal time calculation#586
Merged
jetstack-bot merged 1 commit intocert-manager:release-nextfrom Jun 6, 2021
Merged
Conversation
When this page was merged to release-next, it broke the build on master since these new links do not exist yet on /docs. They only exist in /next-docs. To remediate that, we use a relative path. Signed-off-by: Maël Valais <mael@vls.dev>
jetstack-bot
added
do-not-merge/cherry-pick-not-approved
Contributor
|
Thank you very much for fixing this 🙏🏼 🙏🏼 /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
irbekrm
added
the
cherry-pick-approved
jetstack-bot
removed
the
do-not-merge/cherry-pick-not-approved
maelvls
changed the title
This was referenced Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #570 that is preventing me from merging #585 (comment). When this page was merged to release-next, it broke the build on master since these new links do not exist yet on
/docs. They only exist in/next-docs.To remediate that, we use a relative path.
cc @irbekrm