Skip to content

release-process: mention the code freeze, do not merge master after the first beta#585

Closed
maelvls wants to merge 1 commit intomasterfrom
code-freeze
Closed

release-process: mention the code freeze, do not merge master after the first beta#585
maelvls wants to merge 1 commit intomasterfrom
code-freeze

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Jun 4, 2021

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 4, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2021
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
Copy link
Member Author

maelvls commented Jun 4, 2021

@irbekrm Looks like the linter fails, and I can't change release-next from this PR 😞 Should I open another PR on the release-next branch?

next-docs/release-notes/release-notes-1.4/index.html
  hash does not exist --- next-docs/release-notes/release-notes-1.4/index.html --> ../../../docs/usage/certificate/#renewal
  target does not exist --- next-docs/release-notes/release-notes-1.4/index.html --> ../../../docs/installation/upgrading/remove-deprecated-apis/#upgrading-existing-cert-manager-resources

Update: I created #586 to unblock the situation

@maelvls
Copy link
Member Author

maelvls commented Jun 7, 2021

/test pull-cert-manager-website-verify

@jetstack-bot
Copy link
Contributor

@maelvls: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cert-manager-website-verify ec34383 link /test pull-cert-manager-website-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maelvls
Copy link
Member Author

maelvls commented Jun 15, 2021

I need to update this with what to do for "subsequent betas".

@maelvls
Copy link
Member Author

maelvls commented Jun 15, 2021

I created a branch directly on the repo. I recreated #607 from my branch instead.

@maelvls maelvls closed this Jun 15, 2021
@SgtCoDFish SgtCoDFish deleted the code-freeze branch April 26, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants